tree 6c519e0d656373c0fbe273f4e6eeb5747fa329c7
parent 997faa44e945697717b2eaf22786ba803f741a1e
author Jan Schär <jan@monogon.tech> 1742993843 +0000
committer Jan Schär <jan@monogon.tech> 1744021313 +0000

osbase/net/sshtakeover: refactor package

This is an extensive refactoring of the sshtakeover package.

The package is renamed from //go/net/ssh to //osbase/net/sshtakeover,
to make it more clear what the package is for and avoid clashes with
golang.org/x/crypto/ssh.

The previous Client type was removed, and Dial is now a top-level
function which takes an ssh.ClientConfig. The previous Connection type
was renamed to Client, which makes the naming match ssh.Client.

The Client interface type was moved to //cloud/shepherd/manager. This
allows us to add more functions to sshtakeover.Client without breaking
consumers of the package, which would need to add dummy implementations
for functions which they don't need.

The Upload function was renamed to UploadExecutable, and the new Upload
function can be used for files that don't need to be executable.

The sftp client is now created at the same time as the client, instead
of creating a new one for each uploaded file.

Change-Id: I3be9c346713cb4e5c2b33f9c8c9a6f11ca569a75
Reviewed-on: https://review.monogon.dev/c/monogon/+/4047
Tested-by: Jenkins CI
Reviewed-by: Tim Windelschmidt <tim@monogon.tech>