| commit | 031243f5a276726080a92410f7d3503e5870ed49 | [log] [tgz] |
|---|---|---|
| author | Lorenz Brun <lorenz@monogon.tech> | Tue Aug 24 12:14:27 2021 +0200 |
| committer | Lorenz Brun <lorenz@monogon.tech> | Thu Aug 26 16:02:23 2021 +0000 |
| tree | ab582e63dccf71c27e916d23ea24d5f250774d41 | |
| parent | cbeb8a01de2ac264f41b403b6fdc33dca7b5e568 [diff] |
m/p/devicemapper: fix GC closing control fd The devicemapper package stored a reference to its control file descriptor as a uintptr after opening it thorugh os.Open(). This is a problem as os.newFile (internally called by os.Open) sets a finalizer on the os.File which closes the fd as soon as the object is GCed. Because no such reference was kept by the devicemapper package, the GC could end up closing the fd. To fix this, the package now keeps the original os.File around and just grabs an Fd as necessary. While we're at it, let's make the control file descriptor implementation threadsafe. Change-Id: I6f7e0a398f28c1141627904ccbd2d99dd248bc78 Reviewed-on: https://review.monogon.dev/c/monogon/+/310 Reviewed-by: Sergiusz Bazanski <serge@monogon.tech> Vouch-Run-CI: Lorenz Brun <lorenz@monogon.tech>
This is the main repository containing the source code for the Monogon Project.
⚠️ This is pre-release software that happens to be publicly available. Nothing to see here, please move along.
Our build environment requires a working Podman binary (your distribution should have one).
Spinning up: scripts/create_container.sh
Spinning down: scripts/destroy_container.sh
Running commands: scripts/run_in_container.sh <...>
Using bazel using a wrapper script: scripts/bin/bazel <...> (add to your local $PATH for convenience)
This repository is compatible with the IntelliJ Bazel plugin, which enables full autocompletion for external dependencies and generated code. All commands run inside the container, and necessary paths are mapped into the container.
The following steps are necessary:
Install Google's Bazel plugin in IntelliJ. On IntelliJ 2020.3 or later, you need to install a beta release of the plugin.
Add the absolute path to your ~/.cache/bazel-monogon folder to your idea64.vmoptions (Help → Edit Custom VM Options) and restart IntelliJ:
-Dbazel.bep.path=/home/leopold/.cache/bazel-monogon
Set "Bazel Binary Location" in Other Settings → Bazel Settings to the absolute path of scripts/bin/bazel. This is a wrapper that will execute Bazel inside the container.
Use File → Import Bazel project... to create a new project from .bazelproject.
After running the first sync, everything should now resolve in the IDE, including generated code.
Launch the node:
scripts/bin/bazel run //:launch
Run a kubectl command:
scripts/bin/bazel run //metropolis/cli/dbg -- kubectl describe
Run tests:
scripts/bin/bazel test //...