treewide: compare syscall.Errno directly instead of interface type
Change-Id: I03eba72177113cf40afc38981c5311a8013855f9
Reviewed-on: https://review.monogon.dev/c/monogon/+/3042
Reviewed-by: Leopold Schabel <leo@monogon.tech>
Tested-by: Jenkins CI
diff --git a/metropolis/pkg/kmod/syscall.go b/metropolis/pkg/kmod/syscall.go
index c4e7471..41d3233 100644
--- a/metropolis/pkg/kmod/syscall.go
+++ b/metropolis/pkg/kmod/syscall.go
@@ -19,14 +19,15 @@
if err != nil {
return errors.New("invalid null byte in params")
}
+ var errNo unix.Errno
ctrlErr := sc.Control(func(fd uintptr) {
- _, _, err = unix.Syscall(unix.SYS_FINIT_MODULE, fd, uintptr(unsafe.Pointer(paramsRaw)), flags)
+ _, _, errNo = unix.Syscall(unix.SYS_FINIT_MODULE, fd, uintptr(unsafe.Pointer(paramsRaw)), flags)
})
if ctrlErr != nil {
return fmt.Errorf("unable to get control handle: %w", ctrlErr)
}
- if err != unix.Errno(0) {
- return err
+ if errNo != unix.Errno(0) {
+ return errNo
}
return nil
}
@@ -37,9 +38,9 @@
if err != nil {
return errors.New("invalid null byte in name")
}
- _, _, err = unix.Syscall(unix.SYS_DELETE_MODULE, uintptr(unsafe.Pointer(nameRaw)), flags, 0)
- if err != unix.Errno(0) {
- return err
+ _, _, errNo := unix.Syscall(unix.SYS_DELETE_MODULE, uintptr(unsafe.Pointer(nameRaw)), flags, 0)
+ if errNo != unix.Errno(0) {
+ return errNo
}
- return err
+ return nil
}