Gitiles
Code Review Sign In
gerrit-dev.monogon.dev / monogon / 0ea961c0d2ba446b99852a8f32719c0dfab23b2e
commit0ea961c0d2ba446b99852a8f32719c0dfab23b2e[log] [tgz]
authorJan Schär <jan@jschaer.ch>Thu Apr 11 13:41:40 2024 +0200
committerJan Schär <jan@jschaer.ch>Thu Apr 11 14:53:19 2024 +0000
treefe95facb465d0cac76c4d99db8b31bdc0eef88e4
parent107eb062d8ebbc9a659c67e8fdfe762d1a968edb [diff]
m/p/blockdev: fix discard

Fix various problems with discard. Because discard errors are ignored in 
osimage, these problems were not noticed.

Discard takes byte offsets, not block offsets, and multiple places were 
missing the multiplication with BlockSize.

The BLKDISCARD and BLKZEROOUT ioctls take start and length, not start 
and end.

unix.Fallocate already converts errno 0 to nil.

I manually tested that discard now works correctly in the installer.

Change-Id: I52d9e30a087bb6a792396baaefb2d7d09c43abfe
Reviewed-on: https://review.monogon.dev/c/monogon/+/2953
Tested-by: Jenkins CI
Reviewed-by: Lorenz Brun <lorenz@monogon.tech>
Vouch-Run-CI: Lorenz Brun <lorenz@monogon.tech>
3 files changed
tree: fe95facb465d0cac76c4d99db8b31bdc0eef88e4
  1. .github/
  2. build/
  3. cloud/
  4. go/
  5. intellij/
  6. metropolis/
  7. net/
  8. third_party/
  9. tools/
  10. version/
  11. .bazelignore
  12. .bazelproject
  13. .bazelrc
  14. .bazelrc.ci
  15. .bazelrc.sandboxroot
  16. .bazelversion
  17. .git-ignore-revs
  18. .gitignore
  19. BUILD.bazel
  20. CODING_STANDARDS.md
  21. go.mod
  22. go.sum
  23. LICENSE
  24. MODULE.bazel
  25. MODULE.bazel.lock
  26. README.md
  27. SETUP.md
  28. shell.nix
  29. WORKSPACE
README.md

Monogon Monorepo

This is the main repository containing the source code for the Monogon Platform.

This is pre-release software - take a look, and check back later! In the meantime, join us on Matrix: #monogon-os-community:matrix.org.

Environment

Our build environment is self-contained and requires only minimal host dependencies:

  • A Linux machine or VM.
  • Bazelisk >= v1.15.0 (or a working Nix environment).
  • A reasonably recent kernel with user namespaces enabled.
  • Working KVM with access to /dev/kvm (if you want to run tests).

Our docs assume that Bazelisk is available as bazel on your PATH.

Refer to SETUP.md for detailed instructions.

Monogon OS

The source code lives in //metropolis (Metropolis is the codename of Monogon OS).

See the //metropolis/README.md for a developer quick start guide, or see the Monogon OS Handbook for user documentation.