)]}'
{
  "commit": "1e39914fbcecda7ec236e67f143bbefc31eee9da",
  "tree": "806a09d23eec324d7ff131f42ddfab13cc0f98e0",
  "parents": [
    "20498ddc40079451c83ba3708afc57d820866cb3"
  ],
  "author": {
    "name": "Serge Bazanski",
    "email": "serge@monogon.tech",
    "time": "Tue Oct 22 10:58:15 2024 +0000"
  },
  "committer": {
    "name": "Serge Bazanski",
    "email": "serge@monogon.tech",
    "time": "Wed Oct 30 11:42:51 2024 +0000"
  },
  "message": "metropolis: first pass API for reconfiguring cluster\n\nThis implements management.ConfigureCluster. This API is based around\nProtobuf FieldMasks, which is a new thing in the Metropolis codebase\n(node config mutation is performed via optional fields).\n\nWhether this is the right way to do this is to be discussed.\nAlternatives considered are:\n\n1. Always insert a full new config, providing the old one as a base. The\n   downside of that is the potential conflicts that will spring up the\n   moment we have systems regularly mutate independent parts of the\n   config. Additionally, this might lead to some odd behaviour when\n   dealing with clients that don\u0027t have support for newer versions of\n   the config proto.\n2. Use optional fields, like in Node role code. However, this has the\n   downside of duplicating protos (one for the config state, one for the\n   mutation request). Plus, protobuf optionals are still somewhat\n   unusual.\n3. Provide individual requests for mutating fields (like with Node\n   labels). This also results in a lot of boilerplate code.\n4. Something akin to JSON Patch, but for protobufs, which doesn\u0027t seem\n   to exist.\n\nChange-Id: I42e5eabd42076e947f4bc8399b843e0e1fd48548\nReviewed-on: https://review.monogon.dev/c/monogon/+/3591\nTested-by: Jenkins CI\nReviewed-by: Tim Windelschmidt \u003ctim@monogon.tech\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "1361c9535a853c70a5e470f36d5fb672312f0d90",
      "old_mode": 33188,
      "old_path": "metropolis/node/core/curator/BUILD.bazel",
      "new_id": "86d26299b11c22c3b89a9d44f0d07f95690594d1",
      "new_mode": 33188,
      "new_path": "metropolis/node/core/curator/BUILD.bazel"
    },
    {
      "type": "modify",
      "old_id": "6d5be0f3089f01d0bcffbe74d0f8a826bd19edb9",
      "old_mode": 33188,
      "old_path": "metropolis/node/core/curator/impl_leader.go",
      "new_id": "f40c8d2cbee74c42e4a219438b3f3dda46178329",
      "new_mode": 33188,
      "new_path": "metropolis/node/core/curator/impl_leader.go"
    },
    {
      "type": "modify",
      "old_id": "585cb94dfcdd9a7a8a03bc6ee65b3c20be2a6234",
      "old_mode": 33188,
      "old_path": "metropolis/node/core/curator/impl_leader_management.go",
      "new_id": "0666e9d585df6c16dd0babfb7f257a0d9f4ae198",
      "new_mode": 33188,
      "new_path": "metropolis/node/core/curator/impl_leader_management.go"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "705aa41d4da4ef18734afec020e7e9edd84e65fc",
      "new_mode": 33188,
      "new_path": "metropolis/node/core/curator/reconfigure.go"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "41000a49114d423fbea2bdbfb5952e62a3dacc45",
      "new_mode": 33188,
      "new_path": "metropolis/node/core/curator/reconfigure_test.go"
    },
    {
      "type": "modify",
      "old_id": "f90885a48a2d5de4323ff6222ea6132acdf3273f",
      "old_mode": 33188,
      "old_path": "metropolis/proto/api/BUILD.bazel",
      "new_id": "294dcb858809499a7c6c39e061e0c793b73fd2b3",
      "new_mode": 33188,
      "new_path": "metropolis/proto/api/BUILD.bazel"
    },
    {
      "type": "modify",
      "old_id": "f6900dfc91e007003e8fb912479fa37878764e6c",
      "old_mode": 33188,
      "old_path": "metropolis/proto/api/management.proto",
      "new_id": "0302a796a979592923028118edd1c4c13bbd3ef9",
      "new_mode": 33188,
      "new_path": "metropolis/proto/api/management.proto"
    },
    {
      "type": "modify",
      "old_id": "e526ec32cad238554136895394ab9035a3563c9b",
      "old_mode": 33188,
      "old_path": "metropolis/proto/ext/authorization.proto",
      "new_id": "81de8bd88f8e5159c74669c09f1c087411ce7512",
      "new_mode": 33188,
      "new_path": "metropolis/proto/ext/authorization.proto"
    },
    {
      "type": "modify",
      "old_id": "3519a17d1bacf949b4db98c5433e5e9ee2dd1a3a",
      "old_mode": 33188,
      "old_path": "metropolis/test/e2e/suites/kubernetes/BUILD.bazel",
      "new_id": "a5ec5307be33487f592986e68830f27a6859d25a",
      "new_mode": 33188,
      "new_path": "metropolis/test/e2e/suites/kubernetes/BUILD.bazel"
    },
    {
      "type": "modify",
      "old_id": "cf331260202f020d364439bb6eb8c74282457930",
      "old_mode": 33188,
      "old_path": "metropolis/test/e2e/suites/kubernetes/run_test.go",
      "new_id": "80a829291aabba3f2ed761e172fe967f0e712485",
      "new_mode": 33188,
      "new_path": "metropolis/test/e2e/suites/kubernetes/run_test.go"
    }
  ]
}