treewide: Fix FIELD_LOWER_SNAKE_CASE rule exception
Change-Id: If59edf4c5483416c9779c382a5aafa58c7f73385
Reviewed-on: https://review.monogon.dev/c/monogon/+/3802
Reviewed-by: Leopold Schabel <leo@monogon.tech>
Tested-by: Jenkins CI
diff --git a/metropolis/node/core/curator/state_node.go b/metropolis/node/core/curator/state_node.go
index 93d2a8d..5138134 100644
--- a/metropolis/node/core/curator/state_node.go
+++ b/metropolis/node/core/curator/state_node.go
@@ -281,7 +281,7 @@
for i, p := range n.consensusMember.Peers {
peers[i] = &cpb.NodeRoles_ConsensusMember_Peer{
Name: p.Name,
- URL: p.URL,
+ Url: p.URL,
}
}
msg.Roles.ConsensusMember = &cpb.NodeRoles_ConsensusMember{
@@ -365,7 +365,7 @@
for _, p := range cm.Peers {
peers = append(peers, NodeRoleConsensusMemberPeer{
Name: p.Name,
- URL: p.URL,
+ URL: p.Url,
})
}
n.consensusMember = &NodeRoleConsensusMember{
diff --git a/metropolis/node/core/roleserve/worker_controlplane.go b/metropolis/node/core/roleserve/worker_controlplane.go
index 8b4657a..9a2af52 100644
--- a/metropolis/node/core/roleserve/worker_controlplane.go
+++ b/metropolis/node/core/roleserve/worker_controlplane.go
@@ -185,12 +185,12 @@
// we're starting with.
supervisor.Logger(ctx).Infof("Node role mandates cluster membership with initial peers:")
for _, p := range role.Peers {
- supervisor.Logger(ctx).Infof(" - %s (%s)", p.Name, p.URL)
+ supervisor.Logger(ctx).Infof(" - %s (%s)", p.Name, p.Url)
}
nodes := make([]consensus.ExistingNode, len(role.Peers))
for i, p := range role.Peers {
nodes[i].Name = p.Name
- nodes[i].URL = p.URL
+ nodes[i].URL = p.Url
}
// Build and submit config to startup V.
diff --git a/metropolis/proto/api/BUILD.bazel b/metropolis/proto/api/BUILD.bazel
index 6438ef7..8665c6d 100644
--- a/metropolis/proto/api/BUILD.bazel
+++ b/metropolis/proto/api/BUILD.bazel
@@ -13,7 +13,6 @@
"RPC_REQUEST_STANDARD_NAME", # TODO: evaluate correctness
"RPC_RESPONSE_STANDARD_NAME", # TODO: evaluate correctness
"SERVICE_SUFFIX", # TODO: evaluate correctness
- "FIELD_LOWER_SNAKE_CASE", # TODO: evaluate correctness
],
protos = [":api_proto"],
use_rules = [
diff --git a/metropolis/proto/api/management.proto b/metropolis/proto/api/management.proto
index 8275f43..8653c29 100644
--- a/metropolis/proto/api/management.proto
+++ b/metropolis/proto/api/management.proto
@@ -240,12 +240,12 @@
string id = 4;
}
- // kubernetesController adjusts the appropriate role when set.
- optional bool kubernetesWorker = 2;
- // kubernetesController adjusts the appropriate role when set. Nodes performing
+ // kubernetes_worker adjusts the appropriate role when set.
+ optional bool kubernetes_worker = 2;
+ // kubernetes_controller adjusts the appropriate role when set. Nodes performing
// this role must also be consensus members.
- optional bool kubernetesController = 5;
- optional bool consensusMember = 3;
+ optional bool kubernetes_controller = 5;
+ optional bool consensus_member = 3;
}
message UpdateNodeRolesResponse {
diff --git a/metropolis/proto/common/BUILD.bazel b/metropolis/proto/common/BUILD.bazel
index e34ae51..ec3fa68 100644
--- a/metropolis/proto/common/BUILD.bazel
+++ b/metropolis/proto/common/BUILD.bazel
@@ -9,7 +9,6 @@
"PACKAGE_VERSION_SUFFIX",
"ENUM_VALUE_PREFIX", # TODO: evaluate correctness
"ENUM_ZERO_VALUE_SUFFIX", # TODO: evaluate correctness
- "FIELD_LOWER_SNAKE_CASE", # TODO: evaluate correctness
],
protos = [":common_proto"],
use_rules = [
diff --git a/metropolis/proto/common/common.proto b/metropolis/proto/common/common.proto
index 4580ef2..e7b1b96 100644
--- a/metropolis/proto/common/common.proto
+++ b/metropolis/proto/common/common.proto
@@ -54,8 +54,8 @@
// watcher and curator.Watch.
bytes initial_crl = 3;
message Peer {
- string Name = 1;
- string URL = 2;
+ string name = 1;
+ string url = 2;
}
repeated Peer peers = 4;
}