m/p/logtree: do not emit broken klog entries
Any invalid line parsed to the klog parser would turn into a big INVALID
being emitted to the console, as the emitted log entry had neither a
leveled nor raw logline attached.
Change-Id: Ia6d620ea56d2112d11e2d3edcd6c762c58de6c50
Reviewed-on: https://review.monogon.dev/c/monogon/+/1339
Tested-by: Jenkins CI
Reviewed-by: Lorenz Brun <lorenz@monogon.tech>
diff --git a/metropolis/pkg/logtree/klog.go b/metropolis/pkg/logtree/klog.go
index 1c866f4..9d9b1ee 100644
--- a/metropolis/pkg/logtree/klog.go
+++ b/metropolis/pkg/logtree/klog.go
@@ -85,6 +85,7 @@
// We could instead emit that line as a raw log - however, this would lead to
// interleaving raw logging and leveled logging.
k.publisher.Errorf("Invalid klog line: %s", l.Data)
+ return
}
// TODO(q3k): should this be exposed as an API on LeveledLogger? How much should
// we permit library users to 'fake' logs? This would also permit us to get rid