metropolis: unify utility packages
One last sweeping rename / reshuffle.
We get rid of //metropolis/node/common and //golibs, unifying them into
a single //metropolis/pkg meta-package.
This is to be documented somwhere properly, but here's the new logic
behind selecting where to place a new library package:
- if it's specific to k8s-on-metropolis, put it in
//metropolis/node/kubernetes/*. This is a self-contained tree that
other paths cannot import from.
- if it's a big new subsystem of the metropolis core, put it in
//metropolis/node/core. This can be imported by anything in
//m/n (eg the Kubernetes code at //m/n/kubernetes
- otherwise, treat it as generic library that's part of the metropolis
project, and put it in //metropolis/pkg. This can be imported by
anything within //metropolis.
This will be followed up by a diff that updates visibility rules.
Test Plan: Pure refactor, CI only.
X-Origin-Diff: phab/D683
GitOrigin-RevId: 883e7f09a7d22d64e966d07bbe839454ed081c79
diff --git a/metropolis/node/kubernetes/BUILD.bazel b/metropolis/node/kubernetes/BUILD.bazel
index f1fa849..fe1d806 100644
--- a/metropolis/node/kubernetes/BUILD.bazel
+++ b/metropolis/node/kubernetes/BUILD.bazel
@@ -15,17 +15,17 @@
visibility = ["//metropolis/node:__subpackages__"],
deps = [
"//metropolis/node:go_default_library",
- "//metropolis/node/common/fileargs:go_default_library",
- "//metropolis/node/common/fsquota:go_default_library",
- "//metropolis/node/common/supervisor:go_default_library",
"//metropolis/node/core/localstorage:go_default_library",
"//metropolis/node/core/localstorage/declarative:go_default_library",
- "//metropolis/node/core/logtree:go_default_library",
"//metropolis/node/core/network/dns:go_default_library",
"//metropolis/node/kubernetes/clusternet:go_default_library",
"//metropolis/node/kubernetes/nfproxy:go_default_library",
"//metropolis/node/kubernetes/pki:go_default_library",
"//metropolis/node/kubernetes/reconciler:go_default_library",
+ "//metropolis/pkg/fileargs:go_default_library",
+ "//metropolis/pkg/fsquota:go_default_library",
+ "//metropolis/pkg/logtree:go_default_library",
+ "//metropolis/pkg/supervisor:go_default_library",
"//metropolis/proto/api:go_default_library",
"@com_github_container_storage_interface_spec//lib/go/csi:go_default_library",
"@io_bazel_rules_go//proto/wkt:wrappers_go_proto",
diff --git a/metropolis/node/kubernetes/apiserver.go b/metropolis/node/kubernetes/apiserver.go
index aa706b4..e38c3b3 100644
--- a/metropolis/node/kubernetes/apiserver.go
+++ b/metropolis/node/kubernetes/apiserver.go
@@ -24,10 +24,10 @@
"os/exec"
common "git.monogon.dev/source/nexantic.git/metropolis/node"
- "git.monogon.dev/source/nexantic.git/metropolis/node/common/fileargs"
- "git.monogon.dev/source/nexantic.git/metropolis/node/common/supervisor"
"git.monogon.dev/source/nexantic.git/metropolis/node/core/localstorage"
"git.monogon.dev/source/nexantic.git/metropolis/node/kubernetes/pki"
+ "git.monogon.dev/source/nexantic.git/metropolis/pkg/fileargs"
+ "git.monogon.dev/source/nexantic.git/metropolis/pkg/supervisor"
)
type apiserverService struct {
diff --git a/metropolis/node/kubernetes/clusternet/BUILD.bazel b/metropolis/node/kubernetes/clusternet/BUILD.bazel
index 9e9cc01..49ad828 100644
--- a/metropolis/node/kubernetes/clusternet/BUILD.bazel
+++ b/metropolis/node/kubernetes/clusternet/BUILD.bazel
@@ -10,10 +10,10 @@
visibility = ["//metropolis/node/kubernetes:__subpackages__"],
deps = [
"//metropolis/node:go_default_library",
- "//metropolis/node/common/jsonpatch:go_default_library",
- "//metropolis/node/common/supervisor:go_default_library",
"//metropolis/node/core/localstorage:go_default_library",
- "//metropolis/node/core/logtree:go_default_library",
+ "//metropolis/pkg/jsonpatch:go_default_library",
+ "//metropolis/pkg/logtree:go_default_library",
+ "//metropolis/pkg/supervisor:go_default_library",
"@com_github_vishvananda_netlink//:go_default_library",
"@com_zx2c4_golang_wireguard_wgctrl//:go_default_library",
"@com_zx2c4_golang_wireguard_wgctrl//wgtypes:go_default_library",
diff --git a/metropolis/node/kubernetes/clusternet/clusternet.go b/metropolis/node/kubernetes/clusternet/clusternet.go
index cd78434..28b2ce9 100644
--- a/metropolis/node/kubernetes/clusternet/clusternet.go
+++ b/metropolis/node/kubernetes/clusternet/clusternet.go
@@ -44,10 +44,10 @@
"k8s.io/client-go/tools/cache"
common "git.monogon.dev/source/nexantic.git/metropolis/node"
- "git.monogon.dev/source/nexantic.git/metropolis/node/common/jsonpatch"
- "git.monogon.dev/source/nexantic.git/metropolis/node/common/supervisor"
"git.monogon.dev/source/nexantic.git/metropolis/node/core/localstorage"
- "git.monogon.dev/source/nexantic.git/metropolis/node/core/logtree"
+ "git.monogon.dev/source/nexantic.git/metropolis/pkg/logtree"
+ "git.monogon.dev/source/nexantic.git/metropolis/pkg/jsonpatch"
+ "git.monogon.dev/source/nexantic.git/metropolis/pkg/supervisor"
)
const (
diff --git a/metropolis/node/kubernetes/containerd/BUILD.bazel b/metropolis/node/kubernetes/containerd/BUILD.bazel
index 9e42595..b573588 100644
--- a/metropolis/node/kubernetes/containerd/BUILD.bazel
+++ b/metropolis/node/kubernetes/containerd/BUILD.bazel
@@ -6,8 +6,8 @@
importpath = "git.monogon.dev/source/nexantic.git/metropolis/node/kubernetes/containerd",
visibility = ["//metropolis/node/core:__subpackages__"],
deps = [
- "//metropolis/node/common/supervisor:go_default_library",
"//metropolis/node/core/localstorage:go_default_library",
+ "//metropolis/pkg/supervisor:go_default_library",
"@com_github_containerd_containerd//:go_default_library",
"@com_github_containerd_containerd//namespaces:go_default_library",
],
diff --git a/metropolis/node/kubernetes/containerd/main.go b/metropolis/node/kubernetes/containerd/main.go
index 366f902..af4a898 100644
--- a/metropolis/node/kubernetes/containerd/main.go
+++ b/metropolis/node/kubernetes/containerd/main.go
@@ -30,8 +30,8 @@
ctr "github.com/containerd/containerd"
"github.com/containerd/containerd/namespaces"
- "git.monogon.dev/source/nexantic.git/metropolis/node/common/supervisor"
"git.monogon.dev/source/nexantic.git/metropolis/node/core/localstorage"
+ "git.monogon.dev/source/nexantic.git/metropolis/pkg/supervisor"
)
const (
diff --git a/metropolis/node/kubernetes/controller-manager.go b/metropolis/node/kubernetes/controller-manager.go
index 487511f..107b98e 100644
--- a/metropolis/node/kubernetes/controller-manager.go
+++ b/metropolis/node/kubernetes/controller-manager.go
@@ -23,9 +23,9 @@
"net"
"os/exec"
- "git.monogon.dev/source/nexantic.git/metropolis/node/common/fileargs"
- "git.monogon.dev/source/nexantic.git/metropolis/node/common/supervisor"
"git.monogon.dev/source/nexantic.git/metropolis/node/kubernetes/pki"
+ "git.monogon.dev/source/nexantic.git/metropolis/pkg/fileargs"
+ "git.monogon.dev/source/nexantic.git/metropolis/pkg/supervisor"
)
type controllerManagerConfig struct {
diff --git a/metropolis/node/kubernetes/csi.go b/metropolis/node/kubernetes/csi.go
index 81a94fc..f1ccf8a 100644
--- a/metropolis/node/kubernetes/csi.go
+++ b/metropolis/node/kubernetes/csi.go
@@ -32,10 +32,10 @@
"google.golang.org/grpc/status"
pluginregistration "k8s.io/kubelet/pkg/apis/pluginregistration/v1"
- "git.monogon.dev/source/nexantic.git/metropolis/node/common/fsquota"
- "git.monogon.dev/source/nexantic.git/metropolis/node/common/supervisor"
"git.monogon.dev/source/nexantic.git/metropolis/node/core/localstorage"
- "git.monogon.dev/source/nexantic.git/metropolis/node/core/logtree"
+ "git.monogon.dev/source/nexantic.git/metropolis/pkg/logtree"
+ "git.monogon.dev/source/nexantic.git/metropolis/pkg/fsquota"
+ "git.monogon.dev/source/nexantic.git/metropolis/pkg/supervisor"
)
// Derived from K8s spec for acceptable names, but shortened to 130 characters to avoid issues with
diff --git a/metropolis/node/kubernetes/kubelet.go b/metropolis/node/kubernetes/kubelet.go
index e9c6ce5..fbd9177 100644
--- a/metropolis/node/kubernetes/kubelet.go
+++ b/metropolis/node/kubernetes/kubelet.go
@@ -28,12 +28,12 @@
v1 "k8s.io/apimachinery/pkg/apis/meta/v1"
kubeletconfig "k8s.io/kubelet/config/v1beta1"
- "git.monogon.dev/source/nexantic.git/metropolis/node/common/fileargs"
- "git.monogon.dev/source/nexantic.git/metropolis/node/common/supervisor"
"git.monogon.dev/source/nexantic.git/metropolis/node/core/localstorage"
"git.monogon.dev/source/nexantic.git/metropolis/node/core/localstorage/declarative"
"git.monogon.dev/source/nexantic.git/metropolis/node/kubernetes/pki"
"git.monogon.dev/source/nexantic.git/metropolis/node/kubernetes/reconciler"
+ "git.monogon.dev/source/nexantic.git/metropolis/pkg/fileargs"
+ "git.monogon.dev/source/nexantic.git/metropolis/pkg/supervisor"
)
type kubeletService struct {
diff --git a/metropolis/node/kubernetes/nfproxy/BUILD.bazel b/metropolis/node/kubernetes/nfproxy/BUILD.bazel
index 29124a6..313d79a 100644
--- a/metropolis/node/kubernetes/nfproxy/BUILD.bazel
+++ b/metropolis/node/kubernetes/nfproxy/BUILD.bazel
@@ -6,7 +6,7 @@
importpath = "git.monogon.dev/source/nexantic.git/metropolis/node/kubernetes/nfproxy",
visibility = ["//metropolis/node/kubernetes:__subpackages__"],
deps = [
- "//metropolis/node/common/supervisor:go_default_library",
+ "//metropolis/pkg/supervisor:go_default_library",
"@com_github_sbezverk_nfproxy//pkg/controller:go_default_library",
"@com_github_sbezverk_nfproxy//pkg/nftables:go_default_library",
"@com_github_sbezverk_nfproxy//pkg/proxy:go_default_library",
diff --git a/metropolis/node/kubernetes/nfproxy/nfproxy.go b/metropolis/node/kubernetes/nfproxy/nfproxy.go
index 5fc9a11..cfdfda4 100644
--- a/metropolis/node/kubernetes/nfproxy/nfproxy.go
+++ b/metropolis/node/kubernetes/nfproxy/nfproxy.go
@@ -38,7 +38,7 @@
"k8s.io/client-go/kubernetes/scheme"
"k8s.io/client-go/tools/record"
- "git.monogon.dev/source/nexantic.git/metropolis/node/common/supervisor"
+ "git.monogon.dev/source/nexantic.git/metropolis/pkg/supervisor"
)
type Service struct {
diff --git a/metropolis/node/kubernetes/pki/BUILD.bazel b/metropolis/node/kubernetes/pki/BUILD.bazel
index f82603d..029a85b 100644
--- a/metropolis/node/kubernetes/pki/BUILD.bazel
+++ b/metropolis/node/kubernetes/pki/BUILD.bazel
@@ -11,7 +11,7 @@
visibility = ["//metropolis/node:__subpackages__"],
deps = [
"//metropolis/node:go_default_library",
- "//metropolis/node/core/logtree:go_default_library",
+ "//metropolis/pkg/logtree:go_default_library",
"@io_etcd_go_etcd//clientv3:go_default_library",
"@io_k8s_client_go//tools/clientcmd:go_default_library",
"@io_k8s_client_go//tools/clientcmd/api:go_default_library",
diff --git a/metropolis/node/kubernetes/pki/kubernetes.go b/metropolis/node/kubernetes/pki/kubernetes.go
index 979fec6..e11db29 100644
--- a/metropolis/node/kubernetes/pki/kubernetes.go
+++ b/metropolis/node/kubernetes/pki/kubernetes.go
@@ -30,7 +30,7 @@
configapi "k8s.io/client-go/tools/clientcmd/api"
common "git.monogon.dev/source/nexantic.git/metropolis/node"
- "git.monogon.dev/source/nexantic.git/metropolis/node/core/logtree"
+ "git.monogon.dev/source/nexantic.git/metropolis/pkg/logtree"
)
// KubeCertificateName is an enum-like unique name of a static Kubernetes certificate. The value of the name is used
diff --git a/metropolis/node/kubernetes/provisioner.go b/metropolis/node/kubernetes/provisioner.go
index a9dfa72..de94af4 100644
--- a/metropolis/node/kubernetes/provisioner.go
+++ b/metropolis/node/kubernetes/provisioner.go
@@ -39,10 +39,10 @@
ref "k8s.io/client-go/tools/reference"
"k8s.io/client-go/util/workqueue"
- "git.monogon.dev/source/nexantic.git/metropolis/node/common/fsquota"
- "git.monogon.dev/source/nexantic.git/metropolis/node/common/supervisor"
"git.monogon.dev/source/nexantic.git/metropolis/node/core/localstorage"
- "git.monogon.dev/source/nexantic.git/metropolis/node/core/logtree"
+ "git.monogon.dev/source/nexantic.git/metropolis/pkg/logtree"
+ "git.monogon.dev/source/nexantic.git/metropolis/pkg/fsquota"
+ "git.monogon.dev/source/nexantic.git/metropolis/pkg/supervisor"
)
// ONCHANGE(//metropolis/node/kubernetes/reconciler:resources_csi.go): needs to match csiProvisionerServerName declared.
diff --git a/metropolis/node/kubernetes/reconciler/BUILD.bazel b/metropolis/node/kubernetes/reconciler/BUILD.bazel
index d8f2db6..e4d4f17 100644
--- a/metropolis/node/kubernetes/reconciler/BUILD.bazel
+++ b/metropolis/node/kubernetes/reconciler/BUILD.bazel
@@ -13,7 +13,7 @@
importpath = "git.monogon.dev/source/nexantic.git/metropolis/node/kubernetes/reconciler",
visibility = ["//metropolis/node:__subpackages__"],
deps = [
- "//metropolis/node/common/supervisor:go_default_library",
+ "//metropolis/pkg/supervisor:go_default_library",
"@io_k8s_api//core/v1:go_default_library",
"@io_k8s_api//node/v1beta1:go_default_library",
"@io_k8s_api//policy/v1beta1:go_default_library",
diff --git a/metropolis/node/kubernetes/reconciler/reconciler.go b/metropolis/node/kubernetes/reconciler/reconciler.go
index 0ce84d7..d44a5fe 100644
--- a/metropolis/node/kubernetes/reconciler/reconciler.go
+++ b/metropolis/node/kubernetes/reconciler/reconciler.go
@@ -34,7 +34,7 @@
meta "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/client-go/kubernetes"
- "git.monogon.dev/source/nexantic.git/metropolis/node/common/supervisor"
+ "git.monogon.dev/source/nexantic.git/metropolis/pkg/supervisor"
)
// Sad workaround for all the pointer booleans in K8s specs
diff --git a/metropolis/node/kubernetes/scheduler.go b/metropolis/node/kubernetes/scheduler.go
index 21e6663..7b49963 100644
--- a/metropolis/node/kubernetes/scheduler.go
+++ b/metropolis/node/kubernetes/scheduler.go
@@ -22,9 +22,9 @@
"fmt"
"os/exec"
- "git.monogon.dev/source/nexantic.git/metropolis/node/common/fileargs"
- "git.monogon.dev/source/nexantic.git/metropolis/node/common/supervisor"
"git.monogon.dev/source/nexantic.git/metropolis/node/kubernetes/pki"
+ "git.monogon.dev/source/nexantic.git/metropolis/pkg/fileargs"
+ "git.monogon.dev/source/nexantic.git/metropolis/pkg/supervisor"
)
type schedulerConfig struct {
diff --git a/metropolis/node/kubernetes/service.go b/metropolis/node/kubernetes/service.go
index 2917bfc..db174b6 100644
--- a/metropolis/node/kubernetes/service.go
+++ b/metropolis/node/kubernetes/service.go
@@ -29,13 +29,13 @@
"k8s.io/client-go/kubernetes"
"k8s.io/client-go/tools/clientcmd"
- "git.monogon.dev/source/nexantic.git/metropolis/node/common/supervisor"
"git.monogon.dev/source/nexantic.git/metropolis/node/core/localstorage"
"git.monogon.dev/source/nexantic.git/metropolis/node/core/network/dns"
"git.monogon.dev/source/nexantic.git/metropolis/node/kubernetes/clusternet"
"git.monogon.dev/source/nexantic.git/metropolis/node/kubernetes/nfproxy"
"git.monogon.dev/source/nexantic.git/metropolis/node/kubernetes/pki"
"git.monogon.dev/source/nexantic.git/metropolis/node/kubernetes/reconciler"
+ "git.monogon.dev/source/nexantic.git/metropolis/pkg/supervisor"
apb "git.monogon.dev/source/nexantic.git/metropolis/proto/api"
)