commit 5f1a7de2dfb5db1884fcb677a0bd38daf6dd3c97
author Tim Windelschmidt <tim@monogon.tech> Thu Sep 19 02:00:14 2024 +0200
committer Tim Windelschmidt <tim@monogon.tech> Thu Sep 19 12:06:50 2024 +0000
tree fd52bf35b4b2e6b5c51f56d62424c9d0820ef537
parent e337e938ae8e08dffa3a01045571188413ce70ff

treewide: fix %v in cases where we should use %w

We should always use %w when using fmt.Errorf as you can use error.Is to
compare the underlying error. When printing an error the use of %w is
wrong and should be replaced with %v.

Change-Id: I741111bd91dcee4099144d2ecaffa879fdbb34a2
Reviewed-on: https://review.monogon.dev/c/monogon/+/2993
Tested-by: Jenkins CI
Reviewed-by: Lorenz Brun <lorenz@monogon.tech>

build/analysis/BUILD.bazel

diff --git a/build/analysis/BUILD.bazel b/build/analysis/BUILD.bazel
index a13bef5..a55e759 100644
--- a/build/analysis/BUILD.bazel
+++ b/build/analysis/BUILD.bazel
@@ -63,8 +63,7 @@
 # Append some passes provided by CockroachDB.
 NOGO_PASSES += [
     "@com_github_cockroachdb_cockroach//pkg/testutils/lint/passes/errcmp",
-    # TODO(tim): Enable when fixed
-    # "@com_github_cockroachdb_cockroach//pkg/testutils/lint/passes/errwrap",
+    "@com_github_cockroachdb_cockroach//pkg/testutils/lint/passes/errwrap",
     "@com_github_cockroachdb_cockroach//pkg/testutils/lint/passes/hash",
     "@com_github_cockroachdb_cockroach//pkg/testutils/lint/passes/nilness",
     "@com_github_cockroachdb_cockroach//pkg/testutils/lint/passes/nocopy",