treewide: fix %v in cases where we should use %w
We should always use %w when using fmt.Errorf as you can use error.Is to
compare the underlying error. When printing an error the use of %w is
wrong and should be replaced with %v.
Change-Id: I741111bd91dcee4099144d2ecaffa879fdbb34a2
Reviewed-on: https://review.monogon.dev/c/monogon/+/2993
Tested-by: Jenkins CI
Reviewed-by: Lorenz Brun <lorenz@monogon.tech>
diff --git a/metropolis/node/core/update/update.go b/metropolis/node/core/update/update.go
index 2e30d2a..51dc737 100644
--- a/metropolis/node/core/update/update.go
+++ b/metropolis/node/core/update/update.go
@@ -271,7 +271,7 @@
return s.tryDownloadBundle(ctx, bundleURL, &bundleRaw)
}, backoff.WithContext(b, ctx))
if err != nil {
- return fmt.Errorf("error downloading Metropolis bundle: %v", err)
+ return fmt.Errorf("error downloading Metropolis bundle: %w", err)
}
bundle, err := zip.NewReader(bytes.NewReader(bundleRaw.Bytes()), int64(bundleRaw.Len()))
if err != nil {
@@ -541,12 +541,12 @@
if err == nil {
s.Logger.Infof("Restored missing EFI boot entry for Metropolis")
} else {
- return fmt.Errorf("while restoring missing EFI boot entry for Metropolis: %v", err)
+ return fmt.Errorf("while restoring missing EFI boot entry for Metropolis: %w", err)
}
}
bootOrder, err := efivarfs.GetBootOrder()
if err != nil {
- return fmt.Errorf("failed to get EFI boot order: %v", err)
+ return fmt.Errorf("failed to get EFI boot order: %w", err)
}
for _, bentry := range bootOrder {
if bentry == uint16(validBootEntryIdx) {