treewide: fix %v in cases where we should use %w
We should always use %w when using fmt.Errorf as you can use error.Is to
compare the underlying error. When printing an error the use of %w is
wrong and should be replaced with %v.
Change-Id: I741111bd91dcee4099144d2ecaffa879fdbb34a2
Reviewed-on: https://review.monogon.dev/c/monogon/+/2993
Tested-by: Jenkins CI
Reviewed-by: Lorenz Brun <lorenz@monogon.tech>
diff --git a/metropolis/node/kubernetes/reconciler/reconciler_test.go b/metropolis/node/kubernetes/reconciler/reconciler_test.go
index f457859..5116b0a 100644
--- a/metropolis/node/kubernetes/reconciler/reconciler_test.go
+++ b/metropolis/node/kubernetes/reconciler/reconciler_test.go
@@ -198,7 +198,7 @@
}
if err := reconcile(ctx, r, rname); err != nil {
- return fmt.Errorf("reconcile: %v", err)
+ return fmt.Errorf("reconcile: %w", err)
}
// everything requested should have been created
if diff := r.currentDiff(makeTestObject("foo", 0), makeTestObject("bar", 0), makeTestObject("baz", 0)); diff != "" {
@@ -207,7 +207,7 @@
delete(r.expected, "foo")
if err := reconcile(ctx, r, rname); err != nil {
- return fmt.Errorf("reconcile: %v", err)
+ return fmt.Errorf("reconcile: %w", err)
}
// foo should now be missing
if diff := r.currentDiff(makeTestObject("bar", 0), makeTestObject("baz", 0)); diff != "" {
@@ -216,7 +216,7 @@
r.expected["bar"] = makeTestObject("bar", 1)
if err := reconcile(ctx, r, rname); err != nil {
- return fmt.Errorf("reconcile: %v", err)
+ return fmt.Errorf("reconcile: %w", err)
}
// bar should be updated
if diff := r.currentDiff(makeTestObject("bar", 1), makeTestObject("baz", 0)); diff != "" {