commit | 7ba3152b450889e81e85a02bd2e28f992edba2b0 | [log] [tgz] |
---|---|---|
author | Serge Bazanski <serge@nexantic.com> | Mon Feb 03 16:08:19 2020 +0100 |
committer | Serge Bazanski <serge@nexantic.com> | Mon Feb 03 16:08:19 2020 +0100 |
tree | f543b51e889ff997beff6780e86a2eb4aab6aa50 | |
parent | 71049afd7c1828f5deb660c059527e5d99e8d1c7 [diff] |
core/internal/api: use gRPC statuses as much as possible Returning plain go errors via gRPC will always result in a gRPC 'INTERNAL' error code, which is suboptimal. We go ahead and semanticize some of the possible error paths, and at the same time: - swallow some internal errors into logs and serve sanitized errors - move some of the internal service implementations to also use gRPC statuses - change a panic() call into a status.Unimplemented return type There's still plenty work to be done on this front, but this is a good first change. Test Plan: if this is not covered by tests we're screwed anyways X-Origin-Diff: phab/D366 GitOrigin-RevId: 71880a9e23c65631d6c4df6338855864c34bb11f
This is the monorepo storing all of nexantic's internal projects and libraries.
We assume a Fedora host system provisioned using rW, and IntelliJ as the IDE.
For better reproducibility, all builds are executed in containers.
Spinning up: scripts/create_container.sh
Spinning down: scripts/destroy_container.sh
Running commands: scripts/run_in_container.sh <...>
Using bazel using a wrapper script: scripts/bin/bazel <...>
(add to your local $PATH for convenience)
This repository is compatible with the IntelliJ Bazel plugin. All commands run inside the container, and necessary paths are mapped into the container.
We check the entire .ijwb project directory into the repository, which requires everyone to use the latest version of both IntelliJ and the Bazel plugin, but eliminates manual setup steps.
The following steps are necessary:
Install Google's official Bazel plugin in IntelliJ.
Add the absolute path to your ~/.cache/bazel-nxt folder to your idea64.vmoptions (Help → Edit Custom VM Options) and restart IntelliJ:
-Dbazel.bep.path=/home/leopold/.cache/bazel-nxt
Set "Bazel Binary Location" in Other Settings → Bazel Settings to the absolute path of scripts/bin/bazel. This is a wrapper that will execute Bazel inside the container.
Open the .ijwb
folder as IntelliJ project.
Disable Vgo support for the project.
Run a non-incremental sync in IntelliJ
The plugin will automatically resolve paths for generated files.
If you do not use IntelliJ, you need to use the scripts/bazel_copy_generated_for_ide.sh script to copy files locally.