tree-wide: rewrite ioutil functions to their replacements
The ioutil package has been deprecated in Go 1.16 [1]. This CL removes
all our own users of that package and rewrites them to use their
replacements in the os package. I initially wanted to do this with a
gofix but because all replacements were signature-compatible I just
did it with a few string replaces and then ran goimports to fix up the
imports.
I intentionally didn't rewrite the patches as that would require a
different process and is IMO of less value.
[1] https://github.com/golang/go/issues/42026
Change-Id: Iac6663a1f1ee49f9b1c6e4b3d97e73f2c3b54a13
Reviewed-on: https://review.monogon.dev/c/monogon/+/449
Reviewed-by: Sergiusz Bazanski <serge@monogon.tech>
diff --git a/metropolis/node/kubernetes/containerd/main.go b/metropolis/node/kubernetes/containerd/main.go
index c3dd4a0..b5e2cf0 100644
--- a/metropolis/node/kubernetes/containerd/main.go
+++ b/metropolis/node/kubernetes/containerd/main.go
@@ -20,7 +20,6 @@
"context"
"fmt"
"io"
- "io/ioutil"
"os"
"os/exec"
"path/filepath"
@@ -108,7 +107,7 @@
return fmt.Errorf("failed to connect to containerd: %w", err)
}
logger := supervisor.Logger(ctx)
- preseedNamespaceDirs, err := ioutil.ReadDir(preseedNamespacesDir)
+ preseedNamespaceDirs, err := os.ReadDir(preseedNamespacesDir)
if err != nil {
return fmt.Errorf("failed to open preseed dir: %w", err)
}
@@ -118,7 +117,7 @@
continue
}
namespace := dir.Name()
- images, err := ioutil.ReadDir(filepath.Join(preseedNamespacesDir, namespace))
+ images, err := os.ReadDir(filepath.Join(preseedNamespacesDir, namespace))
if err != nil {
return fmt.Errorf("failed to list namespace preseed directory for ns \"%v\": %w", namespace, err)
}
diff --git a/metropolis/node/kubernetes/plugins/kvmdevice/kvmdevice.go b/metropolis/node/kubernetes/plugins/kvmdevice/kvmdevice.go
index ed47f74..c9a6a79 100644
--- a/metropolis/node/kubernetes/plugins/kvmdevice/kvmdevice.go
+++ b/metropolis/node/kubernetes/plugins/kvmdevice/kvmdevice.go
@@ -27,7 +27,6 @@
"bytes"
"context"
"fmt"
- "io/ioutil"
"net"
"os"
"strconv"
@@ -136,7 +135,7 @@
func (k *Plugin) Run(ctx context.Context) error {
k.logger = supervisor.Logger(ctx)
- l1tfStatus, err := ioutil.ReadFile("/sys/devices/system/cpu/vulnerabilities/l1tf")
+ l1tfStatus, err := os.ReadFile("/sys/devices/system/cpu/vulnerabilities/l1tf")
if err != nil && !os.IsNotExist(err) {
return fmt.Errorf("failed to query for CPU vulnerabilities: %v", err)
}
@@ -148,7 +147,7 @@
return nil
}
- kvmDevRaw, err := ioutil.ReadFile("/sys/devices/virtual/misc/kvm/dev")
+ kvmDevRaw, err := os.ReadFile("/sys/devices/virtual/misc/kvm/dev")
if err != nil {
k.logger.Warning("KVM is not available. Check firmware settings and CPU.")
supervisor.Signal(ctx, supervisor.SignalHealthy)
diff --git a/metropolis/node/kubernetes/provisioner.go b/metropolis/node/kubernetes/provisioner.go
index 42edf77..7288c84 100644
--- a/metropolis/node/kubernetes/provisioner.go
+++ b/metropolis/node/kubernetes/provisioner.go
@@ -20,7 +20,6 @@
"context"
"errors"
"fmt"
- "io/ioutil"
"os"
"path/filepath"
@@ -276,7 +275,7 @@
if err := os.Mkdir(volumePath, 0644); err != nil && !os.IsExist(err) {
return fmt.Errorf("failed to create volume directory: %w", err)
}
- files, err := ioutil.ReadDir(volumePath)
+ files, err := os.ReadDir(volumePath)
if err != nil {
return fmt.Errorf("failed to list files in newly-created volume: %w", err)
}