)]}'
{
  "commit": "87d9c59a3b3dbbd4264f9c8b224e58fc5ff18815",
  "tree": "d927065d7f56bc46207a9df2c60c9c580757e5dd",
  "parents": [
    "5d5d733b9fb3d9892b37840124d959fae07c98b9"
  ],
  "author": {
    "name": "Serge Bazanski",
    "email": "serge@monogon.tech",
    "time": "Wed Mar 20 12:35:11 2024 +0100"
  },
  "committer": {
    "name": "Serge Bazanski",
    "email": "serge@monogon.tech",
    "time": "Wed Mar 20 12:11:01 2024 +0000"
  },
  "message": "m/test/launch/cluster: fix duplicate NodeIDs entries\n\nThis code loop looks for any NEW nodes and inserts them into\ncluster.{Nodes,NodeIDs}. The first structure is a lookup from NodeID to\nnode information, the latter is a list of NodeIDs used to look up\nnumeric node IDs (in order of startup/detection) to NodeIDs.\n\nThe loop in the code runs multiple times to catch any NEW nodes might\ntake a while to appear, and exits once the expected number of nodes have\nbeen detected.\n\nThe bug caused the code to repeatedly insert into Nodes[NodeID] (which\nis fine, but wasteful) and into NodeIDs. The latter resulted in a\nNodeIDs that contained duplicate entries.\n\nTo make sure we only handle each NEW node once, we skip nodes that have\nalready been seen.\n\nThis bug caused us to sometimes act on wrong nodes in E2E tests (any\ntime tests were looking up node number -\u003e node ID -\u003e Node via .NodeIDs\nand .Nodes, they had a chance of picking the wrong node ID / node for a\ngiven node number).\n\nChange-Id: Ie459c8277c0d03902ce23f3b20b0c4e367cc015b\nReviewed-on: https://review.monogon.dev/c/monogon/+/2881\nTested-by: Jenkins CI\nReviewed-by: Lorenz Brun \u003clorenz@monogon.tech\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "e73385dc2b150f6c513ce3a38a4f1cfbe2e44134",
      "old_mode": 33188,
      "old_path": "metropolis/test/launch/cluster/cluster.go",
      "new_id": "14a7307aa18403e597d9cd49e619f3a279f3e96b",
      "new_mode": 33188,
      "new_path": "metropolis/test/launch/cluster/cluster.go"
    }
  ]
}