tree d927065d7f56bc46207a9df2c60c9c580757e5dd
parent 5d5d733b9fb3d9892b37840124d959fae07c98b9
author Serge Bazanski <serge@monogon.tech> 1710934511 +0100
committer Serge Bazanski <serge@monogon.tech> 1710936661 +0000

m/test/launch/cluster: fix duplicate NodeIDs entries

This code loop looks for any NEW nodes and inserts them into
cluster.{Nodes,NodeIDs}. The first structure is a lookup from NodeID to
node information, the latter is a list of NodeIDs used to look up
numeric node IDs (in order of startup/detection) to NodeIDs.

The loop in the code runs multiple times to catch any NEW nodes might
take a while to appear, and exits once the expected number of nodes have
been detected.

The bug caused the code to repeatedly insert into Nodes[NodeID] (which
is fine, but wasteful) and into NodeIDs. The latter resulted in a
NodeIDs that contained duplicate entries.

To make sure we only handle each NEW node once, we skip nodes that have
already been seen.

This bug caused us to sometimes act on wrong nodes in E2E tests (any
time tests were looking up node number -> node ID -> Node via .NodeIDs
and .Nodes, they had a chance of picking the wrong node ID / node for a
given node number).

Change-Id: Ie459c8277c0d03902ce23f3b20b0c4e367cc015b
Reviewed-on: https://review.monogon.dev/c/monogon/+/2881
Tested-by: Jenkins CI
Reviewed-by: Lorenz Brun <lorenz@monogon.tech>