tree 38c893fc96169d4c79a7d699d83158f86f564d04
parent b765f24f8f1c93b817c8a3f4f1eef2514562b140
author Lorenz Brun <lorenz@monogon.tech> 1714477629 +0000
committer Lorenz Brun <lorenz@monogon.tech> 1715597050 +0000

third_party/linux: fix LACP issues

This fixes two major issues with the Linux LACP implementation:
First, the bond interface indicates carrier availability before any port
is even in aggregation state. It pretty much only cares about underlying
port carrier state which is not meaningful in LACP-controlled
aggregation.
Second, individual ports are added to the list of transmitting ports
immediately after coming up. This causes packets to be transmitted
before the LACP state indicates that this should happen.

Fix both of these issues by only enabling ports when the LACP state
machine places them in collecting/distributing state and making the bond
carrier state dependent on ports being enabled. This makes the interface
also behave logically consistent, i.e. it can transmit packets when its
carrier is reported up and not when its carrier is reported down.

While in there, fix some timer-related annoyances which make convergence
unnecessarily slow.

This also comes with a ktest which can be used for testing and
verification of these changes.

Change-Id: I60d0ed483f4f4ccea4d582b80e2bb29ff741783d
Reviewed-on: https://review.monogon.dev/c/monogon/+/3073
Reviewed-by: Serge Bazanski <serge@monogon.tech>
Tested-by: Jenkins CI