m/n/core/cluster: don't cry wolf about missing nodeparams sources
Change-Id: I4498b122dc5c63af89b2c9909250dfc0b6dae732
Reviewed-on: https://review.monogon.dev/c/monogon/+/1390
Tested-by: Jenkins CI
Reviewed-by: Leopold Schabel <leo@monogon.tech>
diff --git a/metropolis/node/core/cluster/cluster.go b/metropolis/node/core/cluster/cluster.go
index c484132..5230939 100644
--- a/metropolis/node/core/cluster/cluster.go
+++ b/metropolis/node/core/cluster/cluster.go
@@ -168,9 +168,14 @@
func (m *Manager) nodeParams(ctx context.Context) (*apb.NodeParameters, error) {
boardName, err := getDMIBoardName()
if err != nil {
- supervisor.Logger(ctx).Warningf("Could not get board name, cannot detect platform: %v", err)
+ if errors.Is(err, os.ErrNotExist) {
+ supervisor.Logger(ctx).Infof("Board name: UNKNOWN")
+ } else {
+ supervisor.Logger(ctx).Warningf("Could not get board name, cannot detect platform: %v", err)
+ }
+ } else {
+ supervisor.Logger(ctx).Infof("Board name: %q", boardName)
}
- supervisor.Logger(ctx).Infof("Board name: %q", boardName)
// When running on GCP, attempt to retrieve the node parameters from the
// metadata server first. Retry until we get a response, since we need to
@@ -197,14 +202,22 @@
// TODO(q3k): probably abstract this away and implement per platform/build/...
paramsFWCFG, err := m.nodeParamsFWCFG(ctx)
if err != nil {
- supervisor.Logger(ctx).Warningf("Could not retrieve node parameters from qemu fwcfg: %v", err)
+ if errors.Is(err, os.ErrNotExist) {
+ supervisor.Logger(ctx).Infof("No qemu fwcfg params.")
+ } else {
+ supervisor.Logger(ctx).Warningf("Could not retrieve node parameters from qemu fwcfg: %v", err)
+ }
paramsFWCFG = nil
} else {
supervisor.Logger(ctx).Infof("Retrieved node parameters from qemu fwcfg")
}
paramsESP, err := m.storageRoot.ESP.Metropolis.NodeParameters.Unmarshal()
if err != nil {
- supervisor.Logger(ctx).Warningf("Could not retrieve node parameters from ESP: %v", err)
+ if errors.Is(err, os.ErrNotExist) {
+ supervisor.Logger(ctx).Infof("No ESP node parameters.")
+ } else {
+ supervisor.Logger(ctx).Warningf("Could not retrieve node parameters from ESP: %v", err)
+ }
paramsESP = nil
} else {
supervisor.Logger(ctx).Infof("Retrieved node parameters from ESP")