m/n/c/consensus: fix handling of status request error
If we don't return here, the next line will panic because status is nil.
This bug was found after enabling WithPropagatePanic in the supervisor
TestHarness.
Change-Id: Ifb6338ebf817fc36f242a231d11af45c39c6c47f
Reviewed-on: https://review.monogon.dev/c/monogon/+/2948
Reviewed-by: Serge Bazanski <serge@monogon.tech>
Vouch-Run-CI: Serge Bazanski <serge@monogon.tech>
Tested-by: Jenkins CI
diff --git a/metropolis/node/core/consensus/consensus.go b/metropolis/node/core/consensus/consensus.go
index 32435e3..f48babc 100644
--- a/metropolis/node/core/consensus/consensus.go
+++ b/metropolis/node/core/consensus/consensus.go
@@ -487,6 +487,7 @@
status, err := cl.Status(ctx, cl.Endpoints()[0])
if err != nil {
supervisor.Logger(ctx).Warningf("Failed to get endpoint status: %v", err)
+ return
}
if status.Leader != status.Header.MemberId {
return