)]}'
{
  "commit": "bd0d24e1fda0ee0cd8231d25eff499894226e04d",
  "tree": "3fb068803b9141172a154df14760a66199cd088c",
  "parents": [
    "7fe19f7b49f4366fcba12b8f3cbef40913370ba9"
  ],
  "author": {
    "name": "Serge Bazanski",
    "email": "serge@nexantic.com",
    "time": "Wed May 19 14:27:36 2021 +0200"
  },
  "committer": {
    "name": "Sergiusz Bazanski",
    "email": "serge@nexantic.com",
    "time": "Thu May 20 10:08:56 2021 +0000"
  },
  "message": "scripts: refactor for reliability\n\nThis is a small refactor/rewrite pass to scripts/create_container.sh and\nscripts/bin/bazel.\n\nFirst of all, it moves the IntelliJ aspect overriding logic from parsing\ncommand line flags in scripts/bin/bazel to replace the path that the\naspect is loaded from to crafting the build container in a way that the\naspect is already located where it\u0027s expected.\n\nThis allows us to vastly simplify the scripts/bin/bazel wrapper, and\nmost notably fixes an issue where it wasn\u0027t able to handle Bazel flags\nthat contained spaces and were wrapped in \"\"/\u0027\u0027 delimited strings.\nInstead of adding more and more flag replacing logic in this script, we\ngot rid of that logic entirely, and now the only thing that the wrapper\nscript does is set the output root and run Bazel within the container.\n\nAt the same time, we also fix discovering newer IntelliJ versions. On my\nmachine, it was still discovering my 2019 installation and using an old\nversion of the aspect.\n\nWe also generally dust off the scripts/create_container.sh script by\nensuring all variables are always used within double quotes (the\nprevious implementation could\u0027ve accidentally removed some directory from\nthe host if the user homedir contained spaces) and moving all of the\nlogic into a function that uses local variables.\n\nTested on my local workstation, IntelliJ sync works.\n\nChange-Id: I63ae042ffe0fc7f384b98768ed66b7426b3f5df4\nReviewed-on: https://review.monogon.dev/c/monogon/+/63\nReviewed-by: Leopold Schabel \u003cleo@nexantic.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "3d4bea7b50a8ff6e2abb5884a7bbb5779f92c705",
      "old_mode": 33261,
      "old_path": "scripts/bin/bazel",
      "new_id": "09cca518dda66065f4bb5e07d6f1e46afcf89918",
      "new_mode": 33261,
      "new_path": "scripts/bin/bazel"
    },
    {
      "type": "modify",
      "old_id": "c5c97d9c1ba5054d41e165d3e701e2bad5edfca5",
      "old_mode": 33261,
      "old_path": "scripts/create_container.sh",
      "new_id": "fcf0787a741521d8dbf82b86397249f2b6b9372e",
      "new_mode": 33261,
      "new_path": "scripts/create_container.sh"
    }
  ]
}