m/p/blockdev: add darwin implementation
This adds a minimal blockdev implementation for Darwin/macOS.
Properly implementing Discard() is left for later as it would require
extending x/sys/unix and it is allowed to just return ErrUnsupported
for all calls.
Change-Id: I5f3c85935301857c1f25edd8b8f9acdbe4abf4ad
Reviewed-on: https://review.monogon.dev/c/monogon/+/1977
Tested-by: Jenkins CI
Reviewed-by: Serge Bazanski <serge@monogon.tech>
diff --git a/metropolis/pkg/blockdev/BUILD.bazel b/metropolis/pkg/blockdev/BUILD.bazel
index c0c98d3..4eff0d4 100644
--- a/metropolis/pkg/blockdev/BUILD.bazel
+++ b/metropolis/pkg/blockdev/BUILD.bazel
@@ -4,6 +4,7 @@
name = "blockdev",
srcs = [
"blockdev.go",
+ "blockdev_darwin.go",
"blockdev_linux.go",
"memory.go",
],
@@ -13,6 +14,12 @@
"@io_bazel_rules_go//go/platform:android": [
"@org_golang_x_sys//unix",
],
+ "@io_bazel_rules_go//go/platform:darwin": [
+ "@org_golang_x_sys//unix",
+ ],
+ "@io_bazel_rules_go//go/platform:ios": [
+ "@org_golang_x_sys//unix",
+ ],
"@io_bazel_rules_go//go/platform:linux": [
"@org_golang_x_sys//unix",
],
diff --git a/metropolis/pkg/blockdev/blockdev_darwin.go b/metropolis/pkg/blockdev/blockdev_darwin.go
new file mode 100644
index 0000000..caecdab
--- /dev/null
+++ b/metropolis/pkg/blockdev/blockdev_darwin.go
@@ -0,0 +1,171 @@
+//go:build darwin
+
+package blockdev
+
+import (
+ "errors"
+ "fmt"
+ "math/bits"
+ "os"
+ "syscall"
+
+ "golang.org/x/sys/unix"
+)
+
+// TODO(lorenz): Upstream these to x/sys/unix.
+const (
+ DKIOCGETBLOCKSIZE = 0x40046418
+ DKIOCGETBLOCKCOUNT = 0x40086419
+)
+
+type Device struct {
+ backend *os.File
+ rawConn syscall.RawConn
+ blockSize int64
+ blockCount int64
+}
+
+func (d *Device) ReadAt(p []byte, off int64) (n int, err error) {
+ return d.backend.ReadAt(p, off)
+}
+
+func (d *Device) WriteAt(p []byte, off int64) (n int, err error) {
+ return d.backend.WriteAt(p, off)
+}
+
+func (d *Device) Close() error {
+ return d.backend.Close()
+}
+
+func (d *Device) BlockCount() int64 {
+ return d.blockCount
+}
+
+func (d *Device) BlockSize() int64 {
+ return d.blockSize
+}
+
+func (d *Device) Discard(startByte int64, endByte int64) error {
+ // Can be implemented using DKIOCUNMAP, but needs x/sys/unix extension.
+ // Not mandatory, so this is fine for now.
+ return ErrUnsupported
+}
+
+func (d *Device) OptimalBlockSize() int64 {
+ return d.blockSize
+}
+
+func (d *Device) Zero(startByte int64, endByte int64) error {
+ // It doesn't look like MacOS even has any zeroing acceleration, so just
+ // use the generic one.
+ return GenericZero(d, startByte, endByte)
+}
+
+// Open opens a block device given a path to its inode.
+func Open(path string) (*Device, error) {
+ outFile, err := os.OpenFile(path, os.O_RDWR, 0640)
+ if err != nil {
+ return nil, fmt.Errorf("failed to open block device: %w", err)
+ }
+ return FromFileHandle(outFile)
+}
+
+// FromFileHandle creates a blockdev from a device handle. The device handle is
+// not duplicated, closing the returned Device will close it. If the handle is
+// not a block device, i.e does not implement block device ioctls, an error is
+// returned.
+func FromFileHandle(handle *os.File) (*Device, error) {
+ outFileC, err := handle.SyscallConn()
+ if err != nil {
+ return nil, fmt.Errorf("error getting SyscallConn: %w", err)
+ }
+ var blockSize int
+ outFileC.Control(func(fd uintptr) {
+ blockSize, err = unix.IoctlGetInt(int(fd), DKIOCGETBLOCKSIZE)
+ })
+ if errors.Is(err, unix.ENOTTY) || errors.Is(err, unix.EINVAL) {
+ return nil, ErrNotBlockDevice
+ } else if err != nil {
+ return nil, fmt.Errorf("when querying disk block size: %w", err)
+ }
+
+ var blockCount int
+ var getSizeErr error
+ outFileC.Control(func(fd uintptr) {
+ blockCount, getSizeErr = unix.IoctlGetInt(int(fd), DKIOCGETBLOCKCOUNT)
+ })
+
+ if getSizeErr != nil {
+ return nil, fmt.Errorf("when querying disk block count: %w", err)
+ }
+ return &Device{
+ backend: handle,
+ rawConn: outFileC,
+ blockSize: int64(blockSize),
+ blockCount: int64(blockCount),
+ }, nil
+}
+
+type File struct {
+ backend *os.File
+ rawConn syscall.RawConn
+ blockSize int64
+ blockCount int64
+}
+
+func CreateFile(name string, blockSize int64, blockCount int64) (*File, error) {
+ if blockSize < 512 {
+ return nil, fmt.Errorf("blockSize must be bigger than 512 bytes")
+ }
+ if bits.OnesCount64(uint64(blockSize)) != 1 {
+ return nil, fmt.Errorf("blockSize must be a power of two")
+ }
+ out, err := os.Create(name)
+ if err != nil {
+ return nil, fmt.Errorf("when creating backing file: %w", err)
+ }
+ rawConn, err := out.SyscallConn()
+ if err != nil {
+ return nil, fmt.Errorf("unable to get SyscallConn: %w", err)
+ }
+ return &File{
+ backend: out,
+ blockSize: blockSize,
+ rawConn: rawConn,
+ blockCount: blockCount,
+ }, nil
+}
+
+func (d *File) ReadAt(p []byte, off int64) (n int, err error) {
+ return d.backend.ReadAt(p, off)
+}
+
+func (d *File) WriteAt(p []byte, off int64) (n int, err error) {
+ return d.backend.WriteAt(p, off)
+}
+
+func (d *File) Close() error {
+ return d.backend.Close()
+}
+
+func (d *File) BlockCount() int64 {
+ return d.blockCount
+}
+
+func (d *File) BlockSize() int64 {
+ return d.blockSize
+}
+
+func (d *File) Discard(startByte int64, endByte int64) error {
+ // Can be supported in the future via fnctl.
+ return ErrUnsupported
+}
+
+func (d *File) OptimalBlockSize() int64 {
+ return d.blockSize
+}
+
+func (d *File) Zero(startByte int64, endByte int64) error {
+ // Can possibly be accelerated in the future via fnctl.
+ return GenericZero(d, startByte, endByte)
+}