treewide: use Fatal in tests instead of Error
Error doesn't return the goroutine, but these cases are final and should end the test case.
Change-Id: I9d87e268b56acd7d1ff5883bb82bf3d74c309176
Reviewed-on: https://review.monogon.dev/c/monogon/+/4044
Reviewed-by: Jan Schär <jan@monogon.tech>
Tested-by: Jenkins CI
diff --git a/metropolis/node/kubernetes/networkpolicy/networkpolicy_test.go b/metropolis/node/kubernetes/networkpolicy/networkpolicy_test.go
index 22cf569..f32dc37 100644
--- a/metropolis/node/kubernetes/networkpolicy/networkpolicy_test.go
+++ b/metropolis/node/kubernetes/networkpolicy/networkpolicy_test.go
@@ -810,21 +810,18 @@
recorder := &testRecorder{t: t}
nft, err := nftctrl.New(recorder, podIfaceGroup)
if err != nil {
- t.Errorf("Failed to create nftctrl: %v", err)
- return
+ t.Fatalf("Failed to create nftctrl: %v", err)
}
defer nft.Close()
kubernetes.nft = nft
if err := kubernetes.initializeNft(); err != nil {
- t.Errorf("nftctrl initialization failed: %v", err)
- return
+ t.Fatalf("nftctrl initialization failed: %v", err)
}
result := interpreter.ExecuteTestCase(testCase)
if result.Err != nil {
- t.Error(result.Err)
- return
+ t.Fatal(result.Err)
}
if !result.Passed(ignoreLoopback) {
printer.PrintTestCaseResult(result)
@@ -863,8 +860,7 @@
recorder := &testRecorder{t: t}
nft, err := nftctrl.New(recorder, podIfaceGroup)
if err != nil {
- t.Errorf("Failed to create nftctrl: %v", err)
- return
+ t.Fatalf("Failed to create nftctrl: %v", err)
}
defer nft.Close()
@@ -874,13 +870,11 @@
}
if err := testCase.init(testCaseState, nft); err != nil {
- t.Errorf("initialization failed: %v", err)
- return
+ t.Fatalf("initialization failed: %v", err)
}
if err := nft.Flush(); err != nil {
- t.Errorf("flush failed: %v", err)
- return
+ t.Fatalf("flush failed: %v", err)
}
parsedPolicy := matcher.BuildNetworkPolicies(true, testCaseState.Policies)