)]}'
{
  "commit": "dd7b2d22fb0e13547505bacd862b92bf56a35983",
  "tree": "ef18d20d2688a62bdf80147ec343e05789ac6cae",
  "parents": [
    "76003f807b24a22476b14bc308939fc62e1ad6a2"
  ],
  "author": {
    "name": "Serge Bazanski",
    "email": "serge@nexantic.com",
    "time": "Fri Jul 02 17:13:22 2021 +0200"
  },
  "committer": {
    "name": "Sergiusz Bazanski",
    "email": "serge@nexantic.com",
    "time": "Fri Jul 02 16:28:59 2021 +0000"
  },
  "message": "third_party/go: add package missing from dependency graph\n\nThis is a Windows-specific package being pulled in by github.com/spf13/cobra.\n\nWe don\u0027t need it, and we don\u0027t ever build it (it\u0027s behind a select()\ngate depending on the Windows platform), but its lack causes us to not\nbe able to perform Bazel queries against anything that stumbles upon\nthis select statement.\n\nNotably, things like ibazel don\u0027t work without the ability to query\ndependencies of a target. In theory, cquery could be used of query (and\ncquery would know that it\u0027s not running on a windows platform and not\nattempt to resolve the missing package). This might happen some day,\nbut:\n\n  1) cquery currently does not support the buildfiles() function, which\n     is needed by tools like ibazel to find not only source/data/target\n     dependencies for a taret, but also every BUILD/.bzl file that\n     influenced that target.\n\n     See: https://github.com/bazelbuild/bazel-watcher/issues/305#issuecomment-627312885\n\n  2) It\u0027s generally good practice to not have missing objects in our\n     dependency graph, I think. We will sooner or later start using this\n     data in CI and other automation, and it might be useful to make an\n     assumption, at some point, that we don\u0027t ever have a broken\n     target dependency graph.\n\nTesting plan: the following now works:\n\n   bazel query \u0027deps(set(//...))\u0027 --output\u003dxml\n\nChange-Id: Ic45e293b868b0aaa707f31384b4b24626ba23e29\nReviewed-on: https://review.monogon.dev/c/monogon/+/200\nReviewed-by: Leopold Schabel \u003cleo@nexantic.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "d4f709eb4373b6020878ca0e9e96a85198825822",
      "old_mode": 33188,
      "old_path": "build/fietsje/deps_kubernetes.go",
      "new_id": "ffd650e5f1ae760f51ec3655b83b04567cd7d669",
      "new_mode": 33188,
      "new_path": "build/fietsje/deps_kubernetes.go"
    },
    {
      "type": "modify",
      "old_id": "bdb76013f61e182fc797f4a92caebd6f864838cd",
      "old_mode": 33188,
      "old_path": "third_party/go/repositories.bzl",
      "new_id": "5778b9c2ab23d0267b3024138c97c9016fd42be9",
      "new_mode": 33188,
      "new_path": "third_party/go/repositories.bzl"
    },
    {
      "type": "modify",
      "old_id": "f5193852d6b9d89abc855d8423c63b1e351b5ee7",
      "old_mode": 33188,
      "old_path": "third_party/go/shelf.pb.text",
      "new_id": "e9bfcefa379b6703332ed8fb5f7a0e452a1be241",
      "new_mode": 33188,
      "new_path": "third_party/go/shelf.pb.text"
    }
  ]
}