m/n/build: format efi.bzl
These are the changes from running buildifier on efi.bzl.
This is in preparation for changing this file as otherwise the
formatting changes would be intertwined with actual changes.
Change-Id: I2e32e011107e5af9301300d927a2196fbe06e574
Reviewed-on: https://review.monogon.dev/c/monogon/+/547
Reviewed-by: Leopold Schabel <leo@nexantic.com>
Reviewed-by: Sergiusz Bazanski <serge@monogon.tech>
Reviewed-by: Mateusz Zalega <mateusz@monogon.tech>
diff --git a/metropolis/node/build/efi.bzl b/metropolis/node/build/efi.bzl
index 12d32db..f9d0f44 100644
--- a/metropolis/node/build/efi.bzl
+++ b/metropolis/node/build/efi.bzl
@@ -9,12 +9,13 @@
def _efi_unified_kernel_image_impl(ctx):
# Find the dependency paths to be passed to mkpayload.
deps = {
- "linux": ctx.file.kernel,
- "initrd": ctx.file.initramfs,
- "osrel": ctx.file.os_release,
- "splash": ctx.file.splash,
- "stub": ctx.file.stub,
+ "linux": ctx.file.kernel,
+ "initrd": ctx.file.initramfs,
+ "osrel": ctx.file.os_release,
+ "splash": ctx.file.splash,
+ "stub": ctx.file.stub,
}
+
# Since cmdline is a string attribute, put it into a file, then append
# that file to deps.
if ctx.attr.cmdline and ctx.attr.cmdline != "":
@@ -24,34 +25,40 @@
content = ctx.attr.cmdline,
)
deps["cmdline"] = cmdline
+
# Get the dm-verity target table from VerityConfig provider.
if ctx.attr.verity:
- deps["rootfs_dm_table"] = ctx.attr.verity[VerityConfig].table
+ deps["rootfs_dm_table"] = ctx.attr.verity[VerityConfig].table
+
# Format deps into command line arguments while keeping track of mkpayload
# runtime inputs.
args = []
inputs = []
for name, file in deps.items():
- if file:
- args.append("-{}={}".format(name, file.path))
- inputs.append(file)
+ if file:
+ args.append("-{}={}".format(name, file.path))
+ inputs.append(file)
+
# Append the output parameter separately, as it doesn't belong with the
# runtime inputs.
image = ctx.actions.declare_file(ctx.attr.name + ".efi")
args.append("-output={}".format(image.path))
+
# Append the objcopy parameter separately, as it's not of File type, and
# it does not constitute an input, since it's part of the toolchain.
objcopy = ctx.attr._toolchain[platform_common.ToolchainInfo].objcopy_executable
args.append("-objcopy={}".format(objcopy))
+
# Run mkpayload.
ctx.actions.run(
- mnemonic = "GenEFIKernelImage",
- progress_message = "Generating EFI unified kernel image",
- inputs = inputs,
- outputs = [image],
- executable = ctx.file._mkpayload,
- arguments = args
+ mnemonic = "GenEFIKernelImage",
+ progress_message = "Generating EFI unified kernel image",
+ inputs = inputs,
+ outputs = [image],
+ executable = ctx.file._mkpayload,
+ arguments = args,
)
+
# Return the unified kernel image file.
return [DefaultInfo(files = depset([image]), runfiles = ctx.runfiles(files = [image]))]