treewide: Unmark ENUM_ZERO_VALUE_SUFFIX rule exception as todo
We don't really have a policy for these, they are chosen arbitrarily.
Change-Id: I705ad309c2a36d794665de2482441858850a1893
Reviewed-on: https://review.monogon.dev/c/monogon/+/3805
Reviewed-by: Lorenz Brun <lorenz@monogon.tech>
Tested-by: Jenkins CI
diff --git a/build/bazel_cc_fix/ccfixspec/BUILD.bazel b/build/bazel_cc_fix/ccfixspec/BUILD.bazel
index ee7f11a..6459390 100644
--- a/build/bazel_cc_fix/ccfixspec/BUILD.bazel
+++ b/build/bazel_cc_fix/ccfixspec/BUILD.bazel
@@ -7,7 +7,7 @@
name = "build_bazel_cc_fix_ccfixspec_proto_lint_test",
except_rules = [
"PACKAGE_VERSION_SUFFIX",
- "ENUM_ZERO_VALUE_SUFFIX", # TODO: evaluate correctness
+ "ENUM_ZERO_VALUE_SUFFIX",
],
protos = [":build_bazel_cc_fix_ccfixspec_proto"],
use_rules = [
diff --git a/cloud/agent/api/BUILD.bazel b/cloud/agent/api/BUILD.bazel
index e07df2d..48139f2 100644
--- a/cloud/agent/api/BUILD.bazel
+++ b/cloud/agent/api/BUILD.bazel
@@ -8,7 +8,7 @@
except_rules = [
"PACKAGE_VERSION_SUFFIX",
"MESSAGE_PASCAL_CASE",
- "ENUM_ZERO_VALUE_SUFFIX", # TODO: evaluate correctness
+ "ENUM_ZERO_VALUE_SUFFIX",
],
protos = [":api_proto"],
use_rules = [
diff --git a/metropolis/node/core/abloader/spec/BUILD.bazel b/metropolis/node/core/abloader/spec/BUILD.bazel
index c53b997..0506d4c 100644
--- a/metropolis/node/core/abloader/spec/BUILD.bazel
+++ b/metropolis/node/core/abloader/spec/BUILD.bazel
@@ -8,7 +8,7 @@
name = "abloader_proto_lint_test",
except_rules = [
"PACKAGE_VERSION_SUFFIX",
- "ENUM_ZERO_VALUE_SUFFIX", # TODO: evaluate correctness
+ "ENUM_ZERO_VALUE_SUFFIX",
],
protos = [":abloader_proto"],
use_rules = [
diff --git a/metropolis/proto/api/BUILD.bazel b/metropolis/proto/api/BUILD.bazel
index bb39de8..e95bb19 100644
--- a/metropolis/proto/api/BUILD.bazel
+++ b/metropolis/proto/api/BUILD.bazel
@@ -7,8 +7,8 @@
name = "api_proto_lint_test",
except_rules = [
"PACKAGE_VERSION_SUFFIX",
+ "ENUM_ZERO_VALUE_SUFFIX",
"RPC_REQUEST_RESPONSE_UNIQUE", # TODO: evaluate correctness
- "ENUM_ZERO_VALUE_SUFFIX", # TODO: evaluate correctness
"RPC_REQUEST_STANDARD_NAME", # TODO: evaluate correctness
"RPC_RESPONSE_STANDARD_NAME", # TODO: evaluate correctness
"SERVICE_SUFFIX", # TODO: evaluate correctness
diff --git a/metropolis/proto/common/BUILD.bazel b/metropolis/proto/common/BUILD.bazel
index f0219fe..8c9b529 100644
--- a/metropolis/proto/common/BUILD.bazel
+++ b/metropolis/proto/common/BUILD.bazel
@@ -7,7 +7,7 @@
name = "common_proto_lint_test",
except_rules = [
"PACKAGE_VERSION_SUFFIX",
- "ENUM_ZERO_VALUE_SUFFIX", # TODO: evaluate correctness
+ "ENUM_ZERO_VALUE_SUFFIX",
],
protos = [":common_proto"],
use_rules = [
diff --git a/osbase/build/fsspec/BUILD.bazel b/osbase/build/fsspec/BUILD.bazel
index 0cb2c55..8b25b28 100644
--- a/osbase/build/fsspec/BUILD.bazel
+++ b/osbase/build/fsspec/BUILD.bazel
@@ -7,7 +7,7 @@
name = "spec_proto_lint_test",
except_rules = [
"PACKAGE_VERSION_SUFFIX",
- "ENUM_ZERO_VALUE_SUFFIX", # TODO: evaluate correctness
+ "ENUM_ZERO_VALUE_SUFFIX",
],
protos = [":spec_proto"],
use_rules = [
diff --git a/osbase/kmod/spec/BUILD.bazel b/osbase/kmod/spec/BUILD.bazel
index 8994546..b3ca466 100644
--- a/osbase/kmod/spec/BUILD.bazel
+++ b/osbase/kmod/spec/BUILD.bazel
@@ -7,7 +7,7 @@
name = "spec_proto_lint_test",
except_rules = [
"PACKAGE_VERSION_SUFFIX",
- "ENUM_ZERO_VALUE_SUFFIX", # TODO: evaluate correctness
+ "ENUM_ZERO_VALUE_SUFFIX",
],
protos = [":spec_proto"],
use_rules = [
diff --git a/osbase/logtree/proto/BUILD.bazel b/osbase/logtree/proto/BUILD.bazel
index 9a87f5c..751faf1 100644
--- a/osbase/logtree/proto/BUILD.bazel
+++ b/osbase/logtree/proto/BUILD.bazel
@@ -7,7 +7,7 @@
name = "proto_proto_lint_test",
except_rules = [
"PACKAGE_VERSION_SUFFIX",
- "ENUM_ZERO_VALUE_SUFFIX", # TODO: evaluate correctness
+ "ENUM_ZERO_VALUE_SUFFIX",
],
protos = [":proto_proto"],
use_rules = [
diff --git a/osbase/net/proto/BUILD.bazel b/osbase/net/proto/BUILD.bazel
index bd69b94..42831da 100644
--- a/osbase/net/proto/BUILD.bazel
+++ b/osbase/net/proto/BUILD.bazel
@@ -7,7 +7,7 @@
name = "proto_proto_lint_test",
except_rules = [
"PACKAGE_VERSION_SUFFIX",
- "ENUM_ZERO_VALUE_SUFFIX", # TODO: evaluate correctness
+ "ENUM_ZERO_VALUE_SUFFIX",
],
protos = [":proto_proto"],
use_rules = [
diff --git a/version/spec/BUILD.bazel b/version/spec/BUILD.bazel
index 5bec9a3..97e63dc 100644
--- a/version/spec/BUILD.bazel
+++ b/version/spec/BUILD.bazel
@@ -7,7 +7,7 @@
name = "spec_proto_lint_test",
except_rules = [
"PACKAGE_VERSION_SUFFIX",
- "ENUM_ZERO_VALUE_SUFFIX", # TODO: evaluate correctness
+ "ENUM_ZERO_VALUE_SUFFIX",
],
protos = [":spec_proto"],
use_rules = [