commit f4d38759600c2f308c4d4c79cfd9b4215d56b34a
author Tim Windelschmidt <tim@monogon.tech> Wed Jan 22 21:59:59 2025 +0100
committer Tim Windelschmidt <tim@monogon.tech> Tue Jan 28 15:44:58 2025 +0000
tree ea31800f2baa3bd6a6db28ca6d106abdf103058c
parent 3eb7d033642ebaaddccde287d5ad3c8c59f7a576

treewide: Unmark ENUM_ZERO_VALUE_SUFFIX rule exception as todo

We don't really have a policy for these, they are chosen arbitrarily.

Change-Id: I705ad309c2a36d794665de2482441858850a1893
Reviewed-on: https://review.monogon.dev/c/monogon/+/3805
Reviewed-by: Lorenz Brun <lorenz@monogon.tech>
Tested-by: Jenkins CI

metropolis/proto/api/BUILD.bazel

diff --git a/metropolis/proto/api/BUILD.bazel b/metropolis/proto/api/BUILD.bazel
index bb39de8..e95bb19 100644
--- a/metropolis/proto/api/BUILD.bazel
+++ b/metropolis/proto/api/BUILD.bazel
@@ -7,8 +7,8 @@
     name = "api_proto_lint_test",
     except_rules = [
         "PACKAGE_VERSION_SUFFIX",
+        "ENUM_ZERO_VALUE_SUFFIX",
         "RPC_REQUEST_RESPONSE_UNIQUE",  # TODO: evaluate correctness
-        "ENUM_ZERO_VALUE_SUFFIX",  # TODO: evaluate correctness
         "RPC_REQUEST_STANDARD_NAME",  # TODO: evaluate correctness
         "RPC_RESPONSE_STANDARD_NAME",  # TODO: evaluate correctness
         "SERVICE_SUFFIX",  # TODO: evaluate correctness

metropolis/proto/common/BUILD.bazel

diff --git a/metropolis/proto/common/BUILD.bazel b/metropolis/proto/common/BUILD.bazel
index f0219fe..8c9b529 100644
--- a/metropolis/proto/common/BUILD.bazel
+++ b/metropolis/proto/common/BUILD.bazel
@@ -7,7 +7,7 @@
     name = "common_proto_lint_test",
     except_rules = [
         "PACKAGE_VERSION_SUFFIX",
-        "ENUM_ZERO_VALUE_SUFFIX",  # TODO: evaluate correctness
+        "ENUM_ZERO_VALUE_SUFFIX",
     ],
     protos = [":common_proto"],
     use_rules = [