commit f525fa74802d2ea61577b188476bea2d54f816d7
author Tim Windelschmidt <tim@monogon.tech> Tue Jan 28 15:31:42 2025 +0100
committer Tim Windelschmidt <tim@monogon.tech> Wed Feb 05 15:45:47 2025 +0000
tree 9603a1111df362b72286e12dc6a0f8f685a349bf
parent b51ecdff88528652297cdaeefa9fd94e7d63f093

treewide: Unmark SERVICE_SUFFIX rule exception as todo

We can't rename the services as it would be a breaking change.

Change-Id: Ib6db1692e80ddff74819df62824b0d1311f11d7d
Reviewed-on: https://review.monogon.dev/c/monogon/+/3817
Reviewed-by: Lorenz Brun <lorenz@monogon.tech>
Tested-by: Jenkins CI

cloud/api/BUILD.bazel

diff --git a/cloud/api/BUILD.bazel b/cloud/api/BUILD.bazel
index 6d67db5..7d471af 100644
--- a/cloud/api/BUILD.bazel
+++ b/cloud/api/BUILD.bazel
@@ -7,7 +7,7 @@
     name = "api_proto_lint_test",
     except_rules = [
         "PACKAGE_VERSION_SUFFIX",
-        "SERVICE_SUFFIX",  # TODO: evaluate correctness
+        "SERVICE_SUFFIX",
     ],
     protos = [":api_proto"],
     use_rules = [

cloud/bmaas/server/api/BUILD.bazel

diff --git a/cloud/bmaas/server/api/BUILD.bazel b/cloud/bmaas/server/api/BUILD.bazel
index 911dbb9..15d649f 100644
--- a/cloud/bmaas/server/api/BUILD.bazel
+++ b/cloud/bmaas/server/api/BUILD.bazel
@@ -9,7 +9,7 @@
         "PACKAGE_VERSION_SUFFIX",
         "RPC_REQUEST_STANDARD_NAME",  # TODO: evaluate correctness
         "RPC_RESPONSE_STANDARD_NAME",  # TODO: evaluate correctness
-        "SERVICE_SUFFIX",  # TODO: evaluate correctness
+        "SERVICE_SUFFIX",
     ],
     protos = [":api_proto"],
     use_rules = [