m/p/tpm/e/internal: remove unsigned comparison against negative value
Change-Id: Id775b09b329aa86c12e52a53f8947428e03ed07b
Reviewed-on: https://review.monogon.dev/c/monogon/+/3018
Tested-by: Jenkins CI
Reviewed-by: Lorenz Brun <lorenz@monogon.tech>
diff --git a/build/analysis/BUILD.bazel b/build/analysis/BUILD.bazel
index ac7036a..a13bef5 100644
--- a/build/analysis/BUILD.bazel
+++ b/build/analysis/BUILD.bazel
@@ -82,9 +82,6 @@
"-QF1006", # could lift into loop condition
"-QF1003", # could use tagged switch
"-QF1008", # Omit embedded fields from selector expression
-
- # TODO: Enable when fixed
- "-SA4003", # no value of type uint32 is less than 0
])
NOGO_PASSES += [
diff --git a/metropolis/pkg/tpm/eventlog/internal/events.go b/metropolis/pkg/tpm/eventlog/internal/events.go
index c95e9dc..4e6c8ad 100644
--- a/metropolis/pkg/tpm/eventlog/internal/events.go
+++ b/metropolis/pkg/tpm/eventlog/internal/events.go
@@ -148,7 +148,7 @@
func UntrustedParseEventType(et uint32) (EventType, error) {
// "The value associated with a UEFI specific platform event type MUST be in
// the range between 0x80000000 and 0x800000FF, inclusive."
- if (et < 0x80000000 && et > 0x800000FF) || (et < 0x0 && et > 0x12) {
+ if (et < 0x80000000 && et > 0x800000FF) || et > 0x12 {
return EventType(0), fmt.Errorf("event type not between [0x0, 0x12] or [0x80000000, 0x800000FF]: got %#x", et)
}
if _, ok := eventTypeNames[EventType(et)]; !ok {