| Lorenz Brun | 6211e4d | 2023-11-14 19:09:40 +0100 | [diff] [blame^] | 1 | From bb611be1b10448316ba21defeede6bec3217febc Mon Sep 17 00:00:00 2001 |
| Lorenz Brun | f2b7ab6 | 2022-05-04 19:06:00 +0200 | [diff] [blame] | 2 | From: Lorenz Brun <lorenz@monogon.tech> |
| Lorenz Brun | 6211e4d | 2023-11-14 19:09:40 +0100 | [diff] [blame^] | 3 | Date: Tue, 14 Nov 2023 13:49:46 +0100 |
| 4 | Subject: [PATCH 1/2] Adapt to K8s 1.28 |
| Lorenz Brun | f2b7ab6 | 2022-05-04 19:06:00 +0200 | [diff] [blame] | 5 | |
| 6 | --- |
| Lorenz Brun | 6211e4d | 2023-11-14 19:09:40 +0100 | [diff] [blame^] | 7 | cmd/nfproxy.go | 6 +++--- |
| 8 | pkg/controller/controller_endpointslice.go | 6 +++--- |
| 9 | pkg/proxy/cache.go | 2 +- |
| 10 | pkg/proxy/proxy.go | 2 +- |
| 11 | pkg/proxy/proxy_endpointslice.go | 2 +- |
| 12 | pkg/proxy/service.go | 4 ++-- |
| 13 | pkg/proxy/tools.go | 2 +- |
| 14 | 7 files changed, 12 insertions(+), 12 deletions(-) |
| Lorenz Brun | f2b7ab6 | 2022-05-04 19:06:00 +0200 | [diff] [blame] | 15 | |
| Lorenz Brun | e6e570a | 2023-11-28 19:23:19 +0100 | [diff] [blame] | 16 | diff --git a/cmd/nfproxy.go b/cmd/nfproxy.go |
| 17 | index 66972ab..83d8b01 100644 |
| 18 | --- a/cmd/nfproxy.go |
| 19 | +++ b/cmd/nfproxy.go |
| Lorenz Brun | 6211e4d | 2023-11-14 19:09:40 +0100 | [diff] [blame^] | 20 | @@ -44,8 +44,8 @@ import ( |
| 21 | "k8s.io/client-go/kubernetes/scheme" |
| 22 | "k8s.io/client-go/tools/record" |
| 23 | "k8s.io/component-base/logs" |
| 24 | + nodeutil "k8s.io/component-helpers/node/util" |
| 25 | "k8s.io/klog" |
| 26 | - utilnode "k8s.io/kubernetes/pkg/util/node" |
| 27 | ) |
| 28 | |
| 29 | var ( |
| 30 | @@ -111,7 +111,7 @@ func main() { |
| 31 | } |
| 32 | |
| 33 | // Create event recorder |
| 34 | - hostname, err := utilnode.GetHostname("") |
| 35 | + hostname, err := nodeutil.GetHostname("") |
| 36 | if err != nil { |
| 37 | klog.Errorf("nfproxy failed to get local host name with error: %+v", err) |
| 38 | os.Exit(1) |
| Lorenz Brun | e6e570a | 2023-11-28 19:23:19 +0100 | [diff] [blame] | 39 | @@ -169,7 +169,7 @@ func main() { |
| 40 | // instantiate EndpointSlice controller, otherwise Endpoints controller will be used. |
| 41 | var ep epController |
| 42 | if endpointSlice { |
| 43 | - ep = controller.NewEndpointSliceController(nfproxy, client, kubeInformerFactory.Discovery().V1beta1().EndpointSlices()) |
| 44 | + ep = controller.NewEndpointSliceController(nfproxy, client, kubeInformerFactory.Discovery().V1().EndpointSlices()) |
| 45 | } else { |
| 46 | ep = controller.NewEndpointsController(nfproxy, client, kubeInformerFactory.Core().V1().Endpoints()) |
| 47 | } |
| 48 | diff --git a/pkg/controller/controller_endpointslice.go b/pkg/controller/controller_endpointslice.go |
| 49 | index ef97ef5..d060a4d 100644 |
| 50 | --- a/pkg/controller/controller_endpointslice.go |
| 51 | +++ b/pkg/controller/controller_endpointslice.go |
| 52 | @@ -20,9 +20,9 @@ import ( |
| 53 | "fmt" |
| 54 | |
| 55 | v1 "k8s.io/api/core/v1" |
| 56 | - discovery "k8s.io/api/discovery/v1beta1" |
| 57 | + discovery "k8s.io/api/discovery/v1" |
| 58 | utilruntime "k8s.io/apimachinery/pkg/util/runtime" |
| 59 | - "k8s.io/client-go/informers/discovery/v1beta1" |
| 60 | + discoveryv1 "k8s.io/client-go/informers/discovery/v1" |
| 61 | "k8s.io/client-go/kubernetes" |
| 62 | "k8s.io/client-go/kubernetes/scheme" |
| 63 | typedcorev1 "k8s.io/client-go/kubernetes/typed/core/v1" |
| 64 | @@ -119,7 +119,7 @@ func (c *endpointSliceController) Start(stopCh <-chan struct{}) error { |
| 65 | func NewEndpointSliceController( |
| 66 | proxy proxy.Proxy, |
| 67 | kubeClientset kubernetes.Interface, |
| 68 | - epSliceInformer v1beta1.EndpointSliceInformer) EndpointSliceController { |
| 69 | + epSliceInformer discoveryv1.EndpointSliceInformer) EndpointSliceController { |
| 70 | |
| 71 | klog.V(4).Info("Creating event broadcaster for EndpointSlice controller") |
| 72 | eventBroadcaster := record.NewBroadcaster() |
| 73 | diff --git a/pkg/proxy/cache.go b/pkg/proxy/cache.go |
| 74 | index 92d06ca..7ef0e6f 100644 |
| 75 | --- a/pkg/proxy/cache.go |
| 76 | +++ b/pkg/proxy/cache.go |
| 77 | @@ -21,7 +21,7 @@ import ( |
| 78 | "sync" |
| 79 | |
| 80 | v1 "k8s.io/api/core/v1" |
| 81 | - discovery "k8s.io/api/discovery/v1beta1" |
| 82 | + discovery "k8s.io/api/discovery/v1" |
| 83 | "k8s.io/apimachinery/pkg/types" |
| 84 | "k8s.io/klog" |
| 85 | ) |
| 86 | diff --git a/pkg/proxy/proxy.go b/pkg/proxy/proxy.go |
| 87 | index 7839820..5876784 100644 |
| 88 | --- a/pkg/proxy/proxy.go |
| 89 | +++ b/pkg/proxy/proxy.go |
| 90 | @@ -22,7 +22,7 @@ import ( |
| 91 | utilnftables "github.com/google/nftables" |
| 92 | "github.com/sbezverk/nfproxy/pkg/nftables" |
| 93 | v1 "k8s.io/api/core/v1" |
| 94 | - discovery "k8s.io/api/discovery/v1beta1" |
| 95 | + discovery "k8s.io/api/discovery/v1" |
| 96 | "k8s.io/apimachinery/pkg/types" |
| 97 | "k8s.io/client-go/tools/record" |
| 98 | "k8s.io/klog" |
| 99 | diff --git a/pkg/proxy/proxy_endpointslice.go b/pkg/proxy/proxy_endpointslice.go |
| 100 | index 5310ed3..5c97096 100644 |
| 101 | --- a/pkg/proxy/proxy_endpointslice.go |
| 102 | +++ b/pkg/proxy/proxy_endpointslice.go |
| 103 | @@ -21,7 +21,7 @@ import ( |
| 104 | "time" |
| 105 | |
| 106 | v1 "k8s.io/api/core/v1" |
| 107 | - discovery "k8s.io/api/discovery/v1beta1" |
| 108 | + discovery "k8s.io/api/discovery/v1" |
| 109 | "k8s.io/klog" |
| 110 | ) |
| 111 | |
| Lorenz Brun | f2b7ab6 | 2022-05-04 19:06:00 +0200 | [diff] [blame] | 112 | diff --git a/pkg/proxy/service.go b/pkg/proxy/service.go |
| Lorenz Brun | e6e570a | 2023-11-28 19:23:19 +0100 | [diff] [blame] | 113 | index 9cc10b7..6e91fae 100644 |
| Lorenz Brun | f2b7ab6 | 2022-05-04 19:06:00 +0200 | [diff] [blame] | 114 | --- a/pkg/proxy/service.go |
| 115 | +++ b/pkg/proxy/service.go |
| 116 | @@ -152,7 +152,7 @@ func newServiceInfo(port *v1.ServicePort, service *v1.Service, baseInfo *BaseSer |
| 117 | |
| 118 | func newBaseServiceInfo(port *v1.ServicePort, service *v1.Service) *BaseServiceInfo { |
| 119 | onlyNodeLocalEndpoints := false |
| 120 | - if apiservice.RequestsOnlyLocalTraffic(service) { |
| 121 | + if apiservice.ExternalPolicyLocal(service) { |
| 122 | onlyNodeLocalEndpoints = true |
| 123 | } |
| 124 | var stickyMaxAgeSeconds int |
| Lorenz Brun | 6211e4d | 2023-11-14 19:09:40 +0100 | [diff] [blame^] | 125 | @@ -175,7 +175,7 @@ func newBaseServiceInfo(port *v1.ServicePort, service *v1.Service) *BaseServiceI |
| 126 | // topologyKeys: service.Spec.TopologyKeys, |
| 127 | svcnft: &nftables.SVCnft{}, |
| 128 | } |
| 129 | - if service.Spec.IPFamilies != nil { |
| 130 | + if len(service.Spec.IPFamilies) > 0 { |
| 131 | info.ipFamilies = service.Spec.IPFamilies |
| 132 | } else { |
| 133 | info.ipFamilies = make([]v1.IPFamily, 1) |
| Lorenz Brun | e6e570a | 2023-11-28 19:23:19 +0100 | [diff] [blame] | 134 | diff --git a/pkg/proxy/tools.go b/pkg/proxy/tools.go |
| 135 | index 06c4ae3..3f7f0b9 100644 |
| 136 | --- a/pkg/proxy/tools.go |
| 137 | +++ b/pkg/proxy/tools.go |
| 138 | @@ -26,7 +26,7 @@ import ( |
| 139 | |
| 140 | utilnftables "github.com/google/nftables" |
| 141 | v1 "k8s.io/api/core/v1" |
| 142 | - discovery "k8s.io/api/discovery/v1beta1" |
| 143 | + discovery "k8s.io/api/discovery/v1" |
| 144 | metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" |
| 145 | "k8s.io/apimachinery/pkg/types" |
| 146 | "k8s.io/apimachinery/pkg/util/intstr" |
| Lorenz Brun | f2b7ab6 | 2022-05-04 19:06:00 +0200 | [diff] [blame] | 147 | -- |
| Lorenz Brun | 6211e4d | 2023-11-14 19:09:40 +0100 | [diff] [blame^] | 148 | 2.40.1 |
| Lorenz Brun | f2b7ab6 | 2022-05-04 19:06:00 +0200 | [diff] [blame] | 149 | |