| Tim Windelschmidt | 6d33a43 | 2025-02-04 14:34:25 +0100 | [diff] [blame^] | 1 | // Copyright The Monogon Project Authors. |
| Serge Bazanski | 9c09c4e | 2020-03-24 13:58:01 +0100 | [diff] [blame] | 2 | // SPDX-License-Identifier: Apache-2.0 |
| Serge Bazanski | 9c09c4e | 2020-03-24 13:58:01 +0100 | [diff] [blame] | 3 | |
| 4 | package supervisor |
| 5 | |
| Serge Bazanski | 216fe7b | 2021-05-21 18:36:16 +0200 | [diff] [blame] | 6 | // Supporting infrastructure to allow running some non-Go payloads under |
| 7 | // supervision. |
| Serge Bazanski | 9c09c4e | 2020-03-24 13:58:01 +0100 | [diff] [blame] | 8 | |
| 9 | import ( |
| 10 | "context" |
| Lorenz Brun | e3032bd | 2023-04-13 14:43:41 +0200 | [diff] [blame] | 11 | "errors" |
| Serge Bazanski | 9c09c4e | 2020-03-24 13:58:01 +0100 | [diff] [blame] | 12 | "net" |
| Lorenz Brun | e3032bd | 2023-04-13 14:43:41 +0200 | [diff] [blame] | 13 | "os" |
| Serge Bazanski | 9c09c4e | 2020-03-24 13:58:01 +0100 | [diff] [blame] | 14 | "os/exec" |
| Serge Bazanski | 216fe7b | 2021-05-21 18:36:16 +0200 | [diff] [blame] | 15 | |
| Serge Bazanski | 9c09c4e | 2020-03-24 13:58:01 +0100 | [diff] [blame] | 16 | "google.golang.org/grpc" |
| Serge Bazanski | 96043bc | 2021-10-05 12:10:13 +0200 | [diff] [blame] | 17 | |
| Tim Windelschmidt | 9f21f53 | 2024-05-07 15:14:20 +0200 | [diff] [blame] | 18 | "source.monogon.dev/osbase/logtree" |
| Serge Bazanski | 9c09c4e | 2020-03-24 13:58:01 +0100 | [diff] [blame] | 19 | ) |
| 20 | |
| Serge Bazanski | 216fe7b | 2021-05-21 18:36:16 +0200 | [diff] [blame] | 21 | // GRPCServer creates a Runnable that serves gRPC requests as longs as it's not |
| 22 | // canceled. |
| 23 | // If graceful is set to true, the server will be gracefully stopped instead of |
| 24 | // plain stopped. This means all pending RPCs will finish, but also requires |
| 25 | // streaming gRPC handlers to check their context liveliness and exit |
| 26 | // accordingly. If the server code does not support this, `graceful` should be |
| 27 | // false and the server will be killed violently instead. |
| Serge Bazanski | 9c09c4e | 2020-03-24 13:58:01 +0100 | [diff] [blame] | 28 | func GRPCServer(srv *grpc.Server, lis net.Listener, graceful bool) Runnable { |
| 29 | return func(ctx context.Context) error { |
| 30 | Signal(ctx, SignalHealthy) |
| Jan Schär | 23e5230 | 2024-03-21 16:50:15 +0100 | [diff] [blame] | 31 | defer func() { |
| 32 | if graceful { |
| 33 | srv.GracefulStop() |
| 34 | } else { |
| 35 | srv.Stop() |
| 36 | } |
| 37 | }() |
| Serge Bazanski | 9c09c4e | 2020-03-24 13:58:01 +0100 | [diff] [blame] | 38 | errC := make(chan error) |
| 39 | go func() { |
| 40 | errC <- srv.Serve(lis) |
| 41 | }() |
| 42 | select { |
| 43 | case <-ctx.Done(): |
| Serge Bazanski | 9c09c4e | 2020-03-24 13:58:01 +0100 | [diff] [blame] | 44 | return ctx.Err() |
| 45 | case err := <-errC: |
| 46 | return err |
| 47 | } |
| 48 | } |
| 49 | } |
| 50 | |
| Serge Bazanski | 216fe7b | 2021-05-21 18:36:16 +0200 | [diff] [blame] | 51 | // RunCommand will create a Runnable that starts a long-running command, whose |
| 52 | // exit is determined to be a failure. |
| Jan Schär | bdbb9c2 | 2024-12-18 15:14:02 +0100 | [diff] [blame] | 53 | // cmd should be created with [exec.CommandContext] so that it will be killed |
| 54 | // when the context is canceled. |
| Serge Bazanski | 0560429 | 2021-03-12 17:47:21 +0100 | [diff] [blame] | 55 | func RunCommand(ctx context.Context, cmd *exec.Cmd, opts ...RunCommandOption) error { |
| Serge Bazanski | 967be21 | 2020-11-02 11:26:59 +0100 | [diff] [blame] | 56 | Signal(ctx, SignalHealthy) |
| Serge Bazanski | 0560429 | 2021-03-12 17:47:21 +0100 | [diff] [blame] | 57 | |
| 58 | var parseKLog bool |
| Lorenz Brun | e3032bd | 2023-04-13 14:43:41 +0200 | [diff] [blame] | 59 | var signal <-chan os.Signal |
| Serge Bazanski | 0560429 | 2021-03-12 17:47:21 +0100 | [diff] [blame] | 60 | for _, opt := range opts { |
| 61 | if opt.parseKlog { |
| 62 | parseKLog = true |
| 63 | } |
| Lorenz Brun | e3032bd | 2023-04-13 14:43:41 +0200 | [diff] [blame] | 64 | if opt.signal != nil { |
| 65 | signal = opt.signal |
| 66 | } |
| Serge Bazanski | 0560429 | 2021-03-12 17:47:21 +0100 | [diff] [blame] | 67 | } |
| 68 | |
| 69 | if parseKLog { |
| 70 | // We make two klogs, one for each of stdout/stderr. This is to prevent |
| 71 | // accidental interleaving of both. |
| 72 | klogStdout := logtree.KLogParser(Logger(ctx)) |
| 73 | defer klogStdout.Close() |
| 74 | klogStderr := logtree.KLogParser(Logger(ctx)) |
| 75 | defer klogStderr.Close() |
| 76 | |
| 77 | cmd.Stdout = klogStdout |
| 78 | cmd.Stderr = klogStderr |
| 79 | } else { |
| 80 | cmd.Stdout = RawLogger(ctx) |
| 81 | cmd.Stderr = RawLogger(ctx) |
| 82 | } |
| Lorenz Brun | e3032bd | 2023-04-13 14:43:41 +0200 | [diff] [blame] | 83 | err := cmd.Start() |
| 84 | if err != nil { |
| 85 | return err |
| 86 | } |
| 87 | |
| 88 | exited := make(chan struct{}) |
| 89 | if signal != nil { |
| 90 | go func() { |
| 91 | for { |
| 92 | var err error |
| 93 | select { |
| 94 | case s := <-signal: |
| 95 | err = cmd.Process.Signal(s) |
| 96 | case <-exited: |
| 97 | return |
| 98 | } |
| 99 | if err != nil && !errors.Is(err, os.ErrProcessDone) { |
| 100 | Logger(ctx).Warningf("Failed sending signal to process: %v", err) |
| 101 | } |
| 102 | } |
| 103 | }() |
| 104 | } |
| 105 | |
| 106 | err = cmd.Wait() |
| 107 | if signal != nil { |
| 108 | exited <- struct{}{} |
| 109 | } |
| Serge Bazanski | 967be21 | 2020-11-02 11:26:59 +0100 | [diff] [blame] | 110 | Logger(ctx).Infof("Command returned: %v", err) |
| 111 | return err |
| Serge Bazanski | 9c09c4e | 2020-03-24 13:58:01 +0100 | [diff] [blame] | 112 | } |
| Serge Bazanski | 0560429 | 2021-03-12 17:47:21 +0100 | [diff] [blame] | 113 | |
| 114 | type RunCommandOption struct { |
| 115 | parseKlog bool |
| Lorenz Brun | e3032bd | 2023-04-13 14:43:41 +0200 | [diff] [blame] | 116 | signal <-chan os.Signal |
| Serge Bazanski | 0560429 | 2021-03-12 17:47:21 +0100 | [diff] [blame] | 117 | } |
| 118 | |
| Serge Bazanski | 216fe7b | 2021-05-21 18:36:16 +0200 | [diff] [blame] | 119 | // ParseKLog signals that the command being run will return klog-compatible |
| 120 | // logs to stdout and/or stderr, and these will be re-interpreted as structured |
| Serge Bazanski | 0560429 | 2021-03-12 17:47:21 +0100 | [diff] [blame] | 121 | // logging and emitted to the supervisor's logger. |
| 122 | func ParseKLog() RunCommandOption { |
| 123 | return RunCommandOption{ |
| 124 | parseKlog: true, |
| 125 | } |
| 126 | } |
| Lorenz Brun | e3032bd | 2023-04-13 14:43:41 +0200 | [diff] [blame] | 127 | |
| 128 | // SignalChan takes a channel which can be used to send signals to the |
| 129 | // supervised process. |
| 130 | // |
| 131 | // The given channel will be read from as long as the underlying process is |
| 132 | // running. If the process doesn't start successfully the channel will not be |
| 133 | // read. When the process exits, the channel will stop being read. |
| 134 | // |
| 135 | // With the above in mind, and also taking into account the inherent lack of |
| 136 | // reliability in delivering any process-handled signals in POSIX/Linux, it is |
| 137 | // recommended to use unbuffered channels, always write to them in a non-blocking |
| 138 | // fashion (eg. in a select { ... default: } block), and to not rely only on the |
| 139 | // signal delivery mechanism for the intended behaviour. |
| 140 | // |
| 141 | // For example, if the signals are used to trigger some configuration reload, |
| 142 | // these configuration reloads should either be verified and signal delivery should |
| 143 | // be retried until confirmed successful, or there should be a backup periodic |
| 144 | // reload performed by the target process independently of signal-based reload |
| 145 | // triggers. |
| 146 | // |
| 147 | // Another example: if the signal delivered is a SIGTERM used to gracefully |
| 148 | // terminate some process, it should be attempted to be delivered a number of |
| 149 | // times before finally SIGKILLing the process. |
| 150 | func SignalChan(s <-chan os.Signal) RunCommandOption { |
| 151 | return RunCommandOption{ |
| 152 | signal: s, |
| 153 | } |
| 154 | } |